From 6251f07ecdf31db1385cf63d9199d05e84a5502e Mon Sep 17 00:00:00 2001 From: Robert Daniel Kortschak Date: Thu, 12 Jun 2014 16:54:10 -0700 Subject: [PATCH] go.tools/present: correctly test empty argument Updates golang/go#7613. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/105130046 --- present/code.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/present/code.go b/present/code.go index a17643564b3..5a299514139 100644 --- a/present/code.go +++ b/present/code.go @@ -239,7 +239,11 @@ func parseArgs(name string, line int, args []string) (res []interface{}, err err case '$': res[i] = "$" case '_': - // Do nothing; '_' indicates an intentionally empty parameter. + if len(v) == 1 { + // Do nothing; "_" indicates an intentionally empty parameter. + break + } + fallthrough default: return nil, fmt.Errorf("%s:%d bad code argument %q", name, line, v) }