Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable eclipse ignoreUnnamedModuleForSplitPackage setting in buildSrc #41285

Open
philwebb opened this issue Jul 2, 2024 · 2 comments
Open
Labels
type: task A general task

Comments

@philwebb
Copy link
Member

philwebb commented Jul 2, 2024

On a fresh Eclipse the following needs to be added to .settings/org.eclipse.jdt.core.prefs for buildSrc. We should try and automate that.

org.eclipse.jdt.core.compiler.ignoreUnnamedModuleForSplitPackage=enabled
@philwebb philwebb added the type: task A general task label Jul 2, 2024
@philwebb philwebb added this to the General Backlog milestone Jul 2, 2024
@wilkinsona
Copy link
Member

I think you already tried that in 4aa4e14. My guess is that the settings are getting clobbered by Java Format but that is just a guess. I tried doing this instead:

eclipse.jdt.file.whenMerged {
	def properties = new Properties()
	load(properties)
	properties.setProperty("org.eclipse.jdt.core.compiler.ignoreUnnamedModuleForSplitPackage", "enabled")
	store(properties)
}

It didn't work.

@philwebb
Copy link
Member Author

I thought I'd fixed it previously. I'm not sure why it stopped working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants