Question: Is this.ackRequests.has(requestId) a redundant condition?

[zishang520]

If requestId does not exist in this.requests, but exists in this.ackRequests:

socket.io-redis-adapter/lib/index.ts

Line 529 in cdb5535

!(this.requests.has(requestId) || this.ackRequests.has(requestId))

L537 will have an exception:

socket.io-redis-adapter/lib/index.ts

Line 537 in cdb5535

const request = this.requests.get(requestId);

[darrachequesne]

Good catch! It looks like it is indeed redundant. Would you mind opening a PR?

[zishang520]

PR submitted.

Although the if(this.ackRequests.has(requestId)) condition in L510 is met and the function is successfully exited, combined with the following code, there may still be problems in some extreme cases? Maybe