Bernoulli Naive Bayes #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first draft of the bernoulli naive bayes implementation. It is missing the Fit function tests and the Predict function.
Refactored the algorithm to use base.Instances. Rewrote the Fit method to pre-calculate priors and conditional probabilities.
Added the logCondProb tests for a simple test case with two classes.
Added predict function along with its test. Current interface is the same of the KNN example. In other words, only the class string is returned from the PredictOne function.
Since the number of instances in each class are stored, there is no need to keep the pre-calculated priors.
|
@sjwhitworth @lazywei I'd be happy to merge this. |
|
Sure thing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a package for Naive Bayes Classifiers. There are other ones that should be implemented (multinomial, gaussian) but this is a start.