Linear regression #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing to note here is that I slightly diverged from previous the Fit() / Predict() interface by returning errors from both. I think this would be a great refactoring in other parts of the library as well... but please let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of linear regression, accompanied by unit tests & benchmarks.
Includes some test data (exams.csv / exam.csv) from here
Tested & compared results using the online calculator available here and results seem to match. Meaning, either my implementation is correct or I have re-implemented the same bugs as xuru.org... 😄
It's also reasonably fast. Single-threaded on my machine: