fix(orchestrator): fix chain-spec cmd custom (paritytech#1476)

* fix(orchestrator): fix chain-spec cmd custom * fmt
shanithkk · Nov 3, 2023 · 878f81c · 878f81c
1 parent e48c162
commit 878f81c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 8 deletions.
diff --git a/javascript/packages/orchestrator/src/configGenerator.ts b/javascript/packages/orchestrator/src/configGenerator.ts
@@ -414,9 +414,9 @@ export async function generateNetworkSpec(
         }
       } else {
         parachainSetup.chainSpecCommand = parachain.chain_spec_command
-          ? config.relaychain.chain_spec_command
+          ? parachain.chain_spec_command
           : `${collatorBinary} build-spec ${
-              parachain.chain ? "--chain " + parachain.chain : ""
+              parachain.chain ? "--chain {{chainName}}" : ""
             } --disable-default-bootnode`;
       }
 

diff --git a/javascript/packages/orchestrator/src/paras.ts b/javascript/packages/orchestrator/src/paras.ts
@@ -91,7 +91,7 @@ export async function generateParachainFiles(
           chainSpecCommand: parachain.chainSpecCommand!,
           defaultImage: parachain.collators[0].image,
         },
-        chainName,
+        parachain.chain,
         chainSpecFullPathPlain,
       );
     }
@@ -157,11 +157,9 @@ export async function generateParachainFiles(
       // Generate the raw chain-spec logic
 
       // Make sure we include the plain chain-spec
-      const chainSpecRawCommand = parachain
-        .chainSpecCommand!.split(" ")
-        .includes("--chain")
-        ? parachain.chainSpecCommand
-        : `${parachain.chainSpecCommand} --chain {{chainName}}`;
+      const chainSpecRawCommand = getChainSpecCmdRaw(
+        parachain.chainSpecCommand!,
+      );
 
       await getChainSpecRaw(
         namespace,
@@ -333,3 +331,16 @@ export async function generateParachainFiles(
 
   return;
 }
+
+function getChainSpecCmdRaw(chainSpecCommand: string) {
+  // Default to the provided cmd, will work for custom generator.
+  let returnCmd = chainSpecCommand;
+  const parts = chainSpecCommand!
+    .split(" ")
+    .filter((part: string) => part.length);
+  if (parts.includes("build-spec") && !parts.includes("--chain")) {
+    returnCmd = `${chainSpecCommand} --chain {{chainName}}`;
+  }
+
+  return returnCmd;
+}