fix(transferstate): make sure it fires even on first load in lazy-loa… #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanderElias
commented
Feb 3, 2020
| @@ -26,7 +27,7 @@ export class IdleMonitorService { | |||
| private appReady = new Event('AngularReady', {bubbles: true, cancelable: false}); | |||
| private appTimeout = new Event('AngularTimeout', {bubbles: true, cancelable: false}); | |||
|
|
|||
| constructor(private zone: NgZone, private router: Router) { | |||
| constructor(private zone: NgZone, private router: Router, private tss: TransferStateService) { | |||
There was a problem hiding this comment.
I'm injecting it here because we are starting the idle-service anyway. This will get refactored in an upcomming PR
jorgeucano
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ded module
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If you use getState for the first time in a lazy-loaded component, its state is not there.
What is the new behavior?
The state from getState is always loaded correctly
Does this PR introduce a breaking change?
Other information
Right now, we are booting the
transferStateServiceon app boot, even of there is no use ofgetStateat all.