-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add raw response to handleError + additional API methods #2
add raw response to handleError + additional API methods #2
Conversation
Hi. I'll definitely get your commit added to the NPM registry, including the methods that I didn't add to the SDK. Can you help me understand your use-case for including the raw JSON? The err object should essentially be a parsed version of the JSON at that point, including data on errors that is specific to a method (like validation errors). There shouldn't be a difference between the JSON and the err object. |
Hi Scott, The reason we want access to the raw JSON is that the parsed error this lib returns doesn't contain all the data we want. I.e. Sometimes an errorCode ( != 0 ) is returned but the raw json contains a gigya user object (with UID, Signature, regToken). We want access to this userData regardless whether an error occured or not. Right now, in case of an errCode all we get is this:
The JSON returned from the gigya does contain a lot more information that is useful to us. Does that clarify our needs? Thanks!
|
I'll fix it so the error object includes everything. I'll also add the missing methods to the SDK. |
Hi scott, Any news on this issue? Thanks, Ilja |
Add raw response to handleError + additional API methods.
Merged. Thanks! |
Thanks! I will remove our fork and depend on [email protected]. Kind regards, I On Thu, Jan 28, 2016 at 11:07 PM, scotthovestadt [email protected]
|
We need the raw response (regToken etc...) when an error occured and some additional API methods for a project we are doing.
Is it possible to publish this to the public npm registry?