Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill() prints histogram in 0.10.1 #437

Closed
alexander-held opened this issue Jul 29, 2020 · 3 comments
Closed

fill() prints histogram in 0.10.1 #437

alexander-held opened this issue Jul 29, 2020 · 3 comments

Comments

@alexander-held
Copy link
Member

Hi, since version 0.10.1, calling a .fill() command on a boost_histogram.Histogram prints the histogram:

import boost_histogram as bh

hist = bh.Histogram(bh.axis.Variable([1,2]))
hist.fill([1])

prints

(array([1]),) None None

while in version 0.10.0 there is no output.


environment: running via python:3.8-slim bash via docker:

boost-histogram==0.10.1
numpy==1.19.1
@henryiii
Copy link
Member

henryiii commented Jul 29, 2020

Not again! I left a debug output in 0.7.0 too. I will see if I can set up a pre-commit check that looks for print statements. I have one that checks for debug statements, like breakpoint(), but not print functions in src.

@henryiii
Copy link
Member

Here it is:

print(args, weight, sample)

I ignored the print output last time, because it was in a lesser-used function, but this one probably needs a patch sooner rather than later.

@henryiii
Copy link
Member

henryiii commented Aug 3, 2020

(This has been fixed in 0.10.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants