Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interactive): Allow to modify filters #1210

Merged
merged 5 commits into from
Sep 8, 2024
Merged

feat(interactive): Allow to modify filters #1210

merged 5 commits into from
Sep 8, 2024

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Aug 26, 2024 •
edited
Loading

Adds the possibility to edit the filter used in the interactive snapshots view:

  • use 'V' to view or change the filter
  • use 'Ctrl-v' to reset to the filter as given to the command

nardoor
nardoor requested changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@nardoor nardoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd advise a small change (removing the unwrap)

src/commands/tui/snapshots.rs Outdated Show resolved Hide resolved
@aawsome aawsome requested a review from nardoor September 8, 2024 13:47
nardoor
nardoor approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@nardoor nardoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from a potential warning on a failed set_filters, I'd say it's good to merge

@aawsome aawsome added this pull request to the merge queue Sep 8, 2024
Merged via the queue into main with commit 1266010 Sep 8, 2024
25 checks passed
@aawsome aawsome deleted the interactive-filter branch September 8, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nardoor nardoor nardoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aawsome @nardoor