Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have "Copy to Clipboard" button on the install page? #1659

Open
okuramasafumi opened this issue Apr 10, 2022 · 3 comments
Open

Can we have "Copy to Clipboard" button on the install page? #1659

okuramasafumi opened this issue Apr 10, 2022 · 3 comments
Labels
C-Enhancement A new feature or request

Comments

@okuramasafumi
Copy link

Summary

On https://www.rust-lang.org/tools/install I'd like to have "Copy to Clipboard" button on the install code.

Motivation

While copy and paste is still possible without the button, I think putting "Copy to Clipboard" button makes it even easier to prevent mistakes.

Drawbacks

We need some amount of JavaScript.
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Interact_with_the_clipboard

Rationale and alternatives

Maintenance

Only a few lines of JavaScript should not be hard to maintain, but some browsers might not support it yet.

Unresolved Questions

@okuramasafumi okuramasafumi added the C-Enhancement A new feature or request label Apr 10, 2022
@haasal
Copy link

haasal commented May 4, 2022

I think it would be a nice and simple addition. I will try to implement it.

What "copy-to-clipboard"-svg should I use. I'm not familiar with the licenses in this case.

Proposition: https://iconduck.com/icons/116901/copy

@AliSajid
Copy link
Contributor

PR #1695 closes this issue.

@AliSajid
Copy link
Contributor

Bumping this for review. There's an active PR (#1695 ) that fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Enhancement A new feature or request
Projects
None yet
Development

No branches or pull requests

4 participants
@AliSajid @okuramasafumi @haasal and others