This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[DSL] Add prettier DSL error #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Instead of saying "invalid Gemfile", can we keep the error message closer to the original? Something like "There was an error while parsing the Gemfile:". It's a small change, but keeping error messages as human-friendly as possible is important. |
…error instead of using the word invalid
segiddins
force-pushed
the
seg-dsl-error
branch
from
21d94f4
to
f37571e
Compare
segiddins
force-pushed
the
seg-dsl-error
branch
from
6d93ffa
to
d6518fe
Compare
|
This should finally be green! It turns out, different rubies have really different ideas on how to report that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes hand in hand with CocoaPods/Core#226.