Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that a connection that detects connectivity issues is transitioned into the "closed" state #561

Closed
michaelklishin opened this issue Aug 13, 2018 · 1 comment
Closed

Ensure that a connection that detects connectivity issues is transitioned into the "closed" state #561

michaelklishin opened this issue Aug 13, 2018 · 1 comment
Labels
bug network operations

Comments

@michaelklishin
Copy link
Member

Currently when a heartbeat is detected, Bunny::Session could be left in a state other than "closed".
Even if connection recovery is underway, the correct state for such connection is nonetheless "closed".

With this change Bunny::Session#send_frameset_without_timeout and friends could then throw a ConnectionClosedError which would be visible to clients. This is closer to how some other clients (e.g. Java) work.

@acogoluegnes @lukebakken FYI.
@michaelklishin
Copy link
Member Author

Credit where credit is due: this was originally suggested in #560.

@sbonebrake sbonebrake mentioned this issue Aug 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug network operations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelklishin