Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubocop/rubocop-minitest
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.35.1
Choose a base ref
...
head repository: rubocop/rubocop-minitest
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.36.0
Choose a head ref
  • 11 commits
  • 12 files changed
  • 3 contributors

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    4d08365 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Accessing an unregistered cop raises useful error

    Currently, when a test class includes `AssertOffense`,
    `AssertOffense#setup` attempts to dynamically identify the Cop under
    test. If the Cop class cannot be found, `#setup` exits early.
    
    In these cases, the test cases continue to execute with a nil `@cop`
    since it wasn't set in `#setup` as expected. When helpers such as
    `#assert_offense` are used, they access `@cop` and the tests can fail
    with cryptic messages such as:
    
    ```
    NoMethodError: undefined method `[]=' for nil
    ```
    
    Initialization of the Cop was refactored to a lazily-called accessor
    method which has the same caching functionality via `@cop`, but raises
    an error if the expected Cop class isn't defined.
    brandoncc committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2c2add0 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge pull request #314 from brandoncc/brandoncc/fail-with-usable-mes…

    …sage-if-cop-not-defined
    
    Tests using AssertOffense should Fail with a usable message if the relevant cop is not defined
    koic committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    859751a View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Configuration menu
    Copy the full SHA
    e901adf View commit details
    Browse the repository at this point in the history
  2. Fix an error for Minitest/MultipleAssertions when using for-style l…

    …oops
    
    They produce an assign node, but the value is part of the parent for node
    Earlopain committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    53d197d View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Enable InternalAffairs/UndefinedConfig

    The described problem doesn't occur anymore
    Earlopain committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    bec9cbb View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge pull request #316 from Earlopain/error-skip-ensure

    Fix an error for `Minitest/SkipEnsure` when only `ensure` has a body
    koic committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    4f75dc5 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #317 from Earlopain/multiple-assertions-error

    Fix an error for `Minitest/MultipleAssertions` when using for-style loops
    koic committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    a3deb85 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #318 from Earlopain/enable-undefined-config

    Enable `InternalAffairs/UndefinedConfig`
    koic committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8a6967d View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Update Changelog

    koic committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    a7452b7 View commit details
    Browse the repository at this point in the history
  2. Cut 0.36.0

    koic committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    68aed47 View commit details
    Browse the repository at this point in the history
Loading