Remove <p></p> around the IDs of preserved chunks #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmcphers Could you review this? |
|
Looks good. |
| # need to remove these empty tags, otherwise we may have invalid HTML like | ||
| # <p><div>...</div></p> | ||
| for (i in names(preserved_chunks)) { | ||
| output_str <- gsub(paste0("<p>", i, "</p>"), i, output_str, fixed = TRUE) |
There was a problem hiding this comment.
I noticed that the call to gsub in restorePreservedChunks includes useBytes = TRUE. Do we need to do that as well here?
There was a problem hiding this comment.
I see you have done it. Usually this is only relevant when the system locale is C and there are multibyte characters to be substituted. It is not harmful to use useBytes = TRUE anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. see