WIP upgrade with Magic type #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
reviewed
Jan 7, 2023
Sosthene00
force-pushed
the
upgrade/new_magic_type
branch
3 times, most recently
from
04c3e4f
to
f941c37
Compare
Kixunil
approved these changes
Jan 7, 2023
|
Let's wait for a new https://github.com/rust-bitcoin/rust-bitcoin release :) |
|
Please rebase over latest master :) |
romanz
force-pushed
the
upgrade/new_magic_type
branch
from
f941c37
to
7e9c7fa
Compare
romanz
force-pushed
the
upgrade/new_magic_type
branch
from
7e9c7fa
to
6aaf7c8
Compare
|
Sorry I just saw your message, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #768
Since then rust-bitcoin has merged a PR that creates a new
Magictype and modifies the api.This PR is only a WIP/placeholder while the change is not tagged in a version of rust-bitcoin, its scope is only the necessary changes to make it work with the new way rust-bitcoin handles network's magic.