Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parse_url_opts to simplify/remove builder.rs #8

Open
kylebarron opened this issue Feb 8, 2024 · 0 comments
Open

Use parse_url_opts to simplify/remove builder.rs #8

kylebarron opened this issue Feb 8, 2024 · 0 comments

Comments

@kylebarron
Copy link
Contributor

In recent versions of object_store, parse_url and parse_url_opts were added. This looks like it should significantly simplify the code in builder.rs.

One drawback so far is that I can't tell how to pass ClientOptions, since that seems to be considered separately from the other options. (I.e. other options are passed to with_config while client options should be passed in to with_client_options)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant