Include ref (commit/tag/branch) in title when printing files.

Fixes slapperwan#877
robhein · Mar 20, 2019 · 383a4c0 · 383a4c0
1 parent 2433593
commit 383a4c0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/src/main/java/com/gh4a/activities/FileViewerActivity.java b/app/src/main/java/com/gh4a/activities/FileViewerActivity.java
@@ -23,8 +23,10 @@
 import android.net.Uri;
 import android.os.Bundle;
 import android.support.annotation.Nullable;
+import android.support.annotation.StringRes;
 import android.support.v4.print.PrintHelper;
 import android.support.v7.widget.PopupMenu;
+import android.text.TextUtils;
 import android.util.Base64;
 import android.view.Menu;
 import android.view.MenuInflater;
@@ -175,8 +177,9 @@ private void findMatchingLines(String data) {
 
     @Override
     protected String getDocumentTitle() {
-        return getString(R.string.file_print_document_title, FileUtils.getFileName(mPath),
-                mRepoOwner, mRepoName);
+        @StringRes int titleResId = TextUtils.isEmpty(mRef)
+                ? R.string.file_print_document_title : R.string.file_print_document_at_ref_title;
+        return getString(titleResId, FileUtils.getFileName(mPath), mRepoOwner, mRepoName, mRef);
     }
 
     @Override

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -526,6 +526,7 @@
     <string name="diff_print_document_title">Diff of file %1$s in commit %2$s in %3$s/%4$s</string>
     <string name="gist_print_document_title">%1$s in gist %2$s of %3$s</string>
     <string name="file_print_document_title">%1$s in %2$s/%3$s</string>
+    <string name="file_print_document_at_ref_title">%1$s in %2$s/%3$s (%4$s)</string>
     <string name="wiki_print_document_title">Wiki page %1$s in %2$s/%3$s</string>
 
     <string name="repository_owner_avatar">Repository owner avatar</string>