You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While implementing the search in hypper we foudn out that most of the code is under cmd for some reason.
As part of the implementation, the relevant code was moved out into a pkg/search as it makes sense to have it there, plus helm does not guarantee that code under cmd will stay, while they will respect the API in pkg.
Maybe we should test the waters upstream to make the change there instead so its more maintainable? Check why the code is in there in the first place?
The text was updated successfully, but these errors were encountered:
Itxaka
changed the title
[Upstream] Move search our of cmd?
[Upstream] Move search out of cmd?
Apr 9, 2021
While implementing the search in hypper we foudn out that most of the code is under cmd for some reason.
As part of the implementation, the relevant code was moved out into a pkg/search as it makes sense to have it there, plus helm does not guarantee that code under cmd will stay, while they will respect the API in pkg.
Maybe we should test the waters upstream to make the change there instead so its more maintainable? Check why the code is in there in the first place?
The text was updated successfully, but these errors were encountered: