Skip to content

Commit

Permalink
Prevent V8 from overridding the RuntimeLibrary cflags
Browse files Browse the repository at this point in the history
Since we're never going to statically link to the runtime library on
Windows (unlink Chromium when built as a monolitic chrome.exe), make
sure that our /M flag setting is also properly set for V8.

Change-Id: Ia17073f6811f43aa264d08c270b1ab841a09408f
Reviewed-by: Michael Bruning <[email protected]>
  • Loading branch information
jturcotte committed Apr 15, 2014
1 parent a674cb3 commit 743a641
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions chromium/v8/build/toolchain.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@
['v8_optimized_debug==0', {
'Optimization': '0',
'conditions': [
['component=="shared_library"', {
['component=="shared_library" or use_qt==1', {
'RuntimeLibrary': '3', # /MDd
}, {
'RuntimeLibrary': '1', # /MTd
Expand All @@ -459,7 +459,7 @@
'StringPooling': 'true',
'BasicRuntimeChecks': '0',
'conditions': [
['component=="shared_library"', {
['component=="shared_library" or use_qt==1', {
'RuntimeLibrary': '3', # /MDd
}, {
'RuntimeLibrary': '1', # /MTd
Expand All @@ -474,7 +474,7 @@
'StringPooling': 'true',
'BasicRuntimeChecks': '0',
'conditions': [
['component=="shared_library"', {
['component=="shared_library" or use_qt==1', {
'RuntimeLibrary': '3', #/MDd
}, {
'RuntimeLibrary': '1', #/MTd
Expand Down Expand Up @@ -666,7 +666,7 @@
'FavorSizeOrSpeed': '0',
'StringPooling': 'true',
'conditions': [
['component=="shared_library"', {
['component=="shared_library" or use_qt==1', {
'RuntimeLibrary': '2', #/MD
}, {
'RuntimeLibrary': '0', #/MT
Expand Down

0 comments on commit 743a641

Please sign in to comment.