You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
message=f"Status check is done, and it's a {result['state']}{emoji} ."
This seems rather straightforward so I'm not immediately sure what is broken here. Can there be some sort of race condition where result["state"] is "success" on L103 but has changed when we reach L112?
The text was updated successfully, but these errors were encountered:
Oh no, I'm stupid. This is actually pretty straightforward. If result["state"] == "success" but there are timed out checks then the f-string will still use "success" even though the if success check fails.
That should be easily fixable. Working on a PR.
I noticed this in python/cpython#94734 and this comment: python/cpython#94734 (comment)
The checks clearly fail:
https://github.com/python/cpython/pull/94734/checks
Islington reports the checks as both being a success but uses the emoji that's being used to indicate that the checks failed.
Relevant code seems to be:
miss-islington/miss_islington/status_change.py
Lines 102 to 112 in 6e5de75
This seems rather straightforward so I'm not immediately sure what is broken here. Can there be some sort of race condition where
result["state"]
is"success"
on L103 but has changed when we reach L112?The text was updated successfully, but these errors were encountered: