Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When requires_dist is not available we should select a package suitable for the python version constraint #2284

Open
abn opened this issue Apr 8, 2020 · 2 comments
Labels
area/installer Related to the dependency installer kind/bug Something isn't working as expected kind/enhancement Not a bug or feature, but improves usability or performance

Comments

@abn
Copy link
Member

abn commented Apr 8, 2020

In cases like #2247 when requires_dist value is not available in the PyPI API response, we fallback to to retrieving the first wheel entry for metadata parsing. This can lead to misleading log messages and potentially, incorrect metadata.

We should improve this by filtering for first available wheel that matches any constraints as best as feasible before arbitrary fallback.

Note: This is especially misleading when downloads take a long time and it gives the illusion of the application being stuck.

@abn abn added the kind/enhancement Not a bug or feature, but improves usability or performance label Apr 8, 2020
@kasteph kasteph added the status/triage This issue needs to be triaged label Apr 13, 2020
@fawolfmann
Copy link

Any update on this issue?

@Secrus Secrus added kind/bug Something isn't working as expected area/installer Related to the dependency installer and removed status/triage This issue needs to be triaged labels May 16, 2022
@ralbertazzi
Copy link
Contributor

Related to: #7935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/installer Related to the dependency installer kind/bug Something isn't working as expected kind/enhancement Not a bug or feature, but improves usability or performance
Projects
None yet
Development

No branches or pull requests

5 participants