Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TVPaint: switch layer IDs for layer names during identification #903

Merged
merged 16 commits into from
Jan 21, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jan 21, 2021

Description

TVPaint implementation used layer ids as unified identifier but it was found out that layer ids are not workfile persistent. Their ids may change if opened on different workstation, in that case all created instances and referenced containers loose track to source of their existence.

Changes

  • layer ids are not used to be stored to metadata as identifiers of created instances or loaded containers
    • layer names are used instead which may not be consistent but are safer than ids
  • this has few disadvantages
    • it is easier to loose track (e.g. on layer rename)
    • TVPaint allows to have multiple layers with same name so some validations are required
      • duplicated layer name validor was added, should care only for layer names that going to be published
  • renamed filename validate_frame_range.py - > validate_render_pass_group.py as it never validated frame range
  • change process order in reference loader on update
    • data about old layers are collected as first step then are removed with old container
    • then new container and new layers are inserted
🏴 this depends on
avalon-core ynput/avalon-core#261

iLLiCiTiT added a commit that referenced this pull request Jan 21, 2021
@iLLiCiTiT iLLiCiTiT self-assigned this Jan 21, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team January 21, 2021 14:03
@mkolar mkolar added this to the 2.15.0 milestone Jan 21, 2021
@mkolar mkolar merged commit a7badaf into 2.x/develop Jan 21, 2021
@mkolar mkolar deleted the feature/tvpaint_without_layer_ids branch January 26, 2021 08:49
@mkolar mkolar changed the title TVPaint without layer ids TVPaint: switch layer IDs for layer names during identification Jan 27, 2021
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Feb 8, 2021
@nextreleaseio nextreleaseio bot mentioned this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants