Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Publishing of tile renderings on Deadline #398

Merged
merged 7 commits into from
Aug 10, 2020

Conversation

antirotor
Copy link
Member

Feature

This feature enable support for publishing tile renders from Maya in Deadline. No matter of assembly method (Draft Tile assembler) this adds publish job to batch waiting for expected files (results from assembly).

How does this works:

In created render instance, check Tile rendering checkbox.
Annotation 2020-07-29 150049

Submit scene via Deadline Maya Client and set your tile settings:
Annotation 2020-07-29 150424

🔵 make sure Job Name matches scene name (can be set with arrow button next to it)
🔴 check Enable Region Rendering
🟢 be sure Single Job Frame matches what you have as start and end frames in Render Settings > Animation

Now you just click Submit Job and jobs will be created on farm under batch name that is current scene name.

After submission is done, you can just Pype > Publish. It will work in similar way as submiting normal render jobs, but without actually submiting those job itselves. It just runs through the code, set everything and submit only Publish job.

If you decide to Publish first or Submit first doesn't matter - only if you Publish first, be aware of version auto-update (Job name in Deadline client will be different then published version). But this is just cosmetics of how it is displayed in Deadline monitor - it still waits for correct data and publishes in correct context.

Caveats:

Deadline Maya Client unfortunately doesn't expose important parameters to be validated/set, such as Single Job Frame and if Region Rendering is actually enabled. Thus it is users responsibility to set and check them manually.

Current implementation doesn't allow sequence (multiple frame) tile rendering.

Implementation Details:

This PR introduce toBeRenderedOn on instance. This adds ability for submit_publish_job to determine, what render farm software is used. Until now we did it only by presence of DeadlineSubmitJob or MusterSubmitJob but this PR introduce valid state, where this job doesn't exist. This must be set on instance prior this plugin and this PR already modifies submit_*_deadline scripts for all supported hosts to include this.

We also skips frame range validator for this, just checking if start frame == end frame. This is probably overkill and should be already handled by assets start/end frame.

It has merged in #376

Closes #297
Closes #376

🎫 Freshdesk Ticked ID: #24

@antirotor antirotor added type: enhancement Enhancements to existing functionality host: Maya affects: USER labels Jul 29, 2020
@antirotor antirotor requested a review from a team July 29, 2020 13:23
@antirotor antirotor self-assigned this Jul 29, 2020
@mkolar
Copy link
Member

mkolar commented Aug 5, 2020

The tile seems to work, however I'm unable to publish standard render now. It is trying to format a list after it collects expected files.

image

Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the comment above. unable to publish normal render now :)

@antirotor antirotor requested a review from mkolar August 7, 2020 15:18
@antirotor
Copy link
Member Author

It should work now

@mkolar
Copy link
Member

mkolar commented Aug 10, 2020

Works for standard renders. I'm unable to test tiles without draft license, but let's merge to we can do proper testing.

@mkolar mkolar added this to the 2.12 milestone Aug 10, 2020
@mkolar mkolar merged commit 76a6ac6 into 2.x/develop Aug 10, 2020
@mkolar mkolar deleted the feature/maya-tile-rendering branch August 13, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants