Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Add OCIO as submodule to prepare for handling maketx color space conversion. #3590

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2022

Brief description

maketx executable requires an OCIO config file path appended when using the --colorconfig flag. This resolves #3584 and prepares for preventing maketx from crashing when publishing OpenPype Look instances.

Description

Adding OCIO as a submodule and adding functionality to grab the OCIO config file path based on a profile folder parameter as the function argument.

Testing:

  1. Create some geo and OP model instance.
  2. Publish it.
  3. load model instance in.
  4. Create shader, apply a test base color texture (that's in sRGB).
  5. publish it.

The publishing should produce a .tx file that's optimized for MtoA. (Make sure create .tx is enabled in the look creator)

@ghost ghost added type: bug Something isn't working host: Maya labels Jul 28, 2022
@ghost ghost self-assigned this Jul 28, 2022
@ynbot
Copy link
Contributor

ynbot commented Jul 28, 2022

@ghost ghost requested review from antirotor and iLLiCiTiT July 28, 2022 09:39
@ghost ghost requested a review from m-u-r-p-h-y July 28, 2022 10:49
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested per instructions

publishing went smoothly, with tx file generated

// pyblish.ExtractLook : tx: converting sRGB -> linear // 
// pyblish.ExtractLook : Generating .tx file for D:\PROJECTS\murphy_22101\assets\props\testProp2\work\lookdev\macbeth_srgb.tif .. // 
// pyblish.ExtractLook : file will be copied C:\Users\murph\AppData\Local\Temp\pyblish_tmp_ozlxpjrw\resources\macbeth_srgb.tx -> D:\PROJECTS\murphy_22101\assets\props\testProp2\publish\look\lookMain\v001\resources\macbeth_srgb.tx // 
// 

Allan Ihsan added 2 commits July 29, 2022 12:22
@jakubjezek001 jakubjezek001 self-requested a review July 29, 2022 11:48
@iLLiCiTiT iLLiCiTiT merged commit f6b8c5c into develop Jul 29, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/OP-3657_maketx-built-with-OCIO-support-requires-config branch July 29, 2022 12:29
@BigRoy
Copy link
Collaborator

BigRoy commented Aug 10, 2022

Just want to mention here that this PR adds a 2.3 GB file size to OpenPype builds and installs as I mentioned on discord. The code currently only uses the 2.3 MB nuke-default folder so it might be the easiest quick fix for now to only include that somehow.

@antirotor
Copy link
Member

we've decided to have our own forked and curated set that should be used instead, not just for that particular issue but also for proper support of color management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maketx built with OCIO support requires config
6 participants