-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Add OCIO as submodule to prepare for handling maketx
color space conversion.
#3590
Bugfix: Add OCIO as submodule to prepare for handling maketx
color space conversion.
#3590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested per instructions
publishing went smoothly, with tx file generated
// pyblish.ExtractLook : tx: converting sRGB -> linear //
// pyblish.ExtractLook : Generating .tx file for D:\PROJECTS\murphy_22101\assets\props\testProp2\work\lookdev\macbeth_srgb.tif .. //
// pyblish.ExtractLook : file will be copied C:\Users\murph\AppData\Local\Temp\pyblish_tmp_ozlxpjrw\resources\macbeth_srgb.tx -> D:\PROJECTS\murphy_22101\assets\props\testProp2\publish\look\lookMain\v001\resources\macbeth_srgb.tx //
//
Just want to mention here that this PR adds a 2.3 GB file size to OpenPype builds and installs as I mentioned on discord. The code currently only uses the 2.3 MB |
we've decided to have our own forked and curated set that should be used instead, not just for that particular issue but also for proper support of color management. |
Brief description
maketx
executable requires anOCIO
config file path appended when using the--colorconfig
flag. This resolves #3584 and prepares for preventingmaketx
from crashing when publishing OpenPypeLook
instances.Description
Adding OCIO as a submodule and adding functionality to grab the OCIO config file path based on a profile folder parameter as the function argument.
Testing:
The publishing should produce a
.tx
file that's optimized forMtoA
. (Make sure create .tx is enabled in the look creator)