Nuke: improving readability

[jakubjezek001]

Brief description

Code was too complex to read

Testing notes:

1. configure project_settings/nuke/publish/ExtractReviewDataMov/outputs to have multiple presets with use of filters
2. open your testing nuke script
3. publish render write node

[BigRoy]

I agree with @iLLiCiTiT this comment is likely the best format. Which makes it something like this:

# please consider example as pseudocode - untested
...

                # process only allowed families
                if f_families:
                    if set(families).intersection(f_families):
                        continue

                # process only allowed task types
                if f_task_types:
                    if task_type in f_task_types:
                        continue
                        
                # process only subsets matching patterns
                if f_subsets:
                    if any(re.search(pattern, subset) 
                           for pattern in f_subsets)):
                       continue

I believe above logic says that if it matches any of the filters then they are continued and excluded which might be the opposite of what you'd need? :D

This also means the lines below it where you check all can be removed:

                # we need all filters to be positive for this
                # preset to be activated
                test_all = all([
                    test_families,
                    test_task_types,
                    test_subsets
                ])

                # if it is not positive then skip this preset
                if not test_all:
                    continue

[jakubjezek001]

I agree with @iLLiCiTiT this comment is likely the best format. Which makes it something like this:

# please consider example as pseudocode - untested
...

                # process only allowed families
                if f_families:
                    if set(families).intersection(f_families):
                        continue

                # process only allowed task types
                if f_task_types:
                    if task_type in f_task_types:
                        continue
                        
                # process only subsets matching patterns
                if f_subsets:
                    if any(re.search(pattern, subset) 
                           for pattern in f_subsets)):
                       continue

I believe above logic says that if it matches any of the filters then they are continued and excluded which might be the opposite of what you'd need? :D

This also means the lines below it where you check all can be removed:

                # we need all filters to be positive for this
                # preset to be activated
                test_all = all([
                    test_families,
                    test_task_types,
                    test_subsets
                ])

                # if it is not positive then skip this preset
                if not test_all:
                    continue

Brilliant! Thank you @BigRoy . Code looks and reads much better this way ;)