Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: Don't validate vendor bin with executing them #2317

Merged
merged 3 commits into from
Nov 29, 2021
Merged

General: Don't validate vendor bin with executing them #2317

merged 3 commits into from
Nov 29, 2021

Conversation

iLLiCiTiT
Copy link
Member

Issue

Vendorized binaries existence is validated by executing their executables which is slow and triggering console windows from openpype gui.

Changes

  • validation happens by checking existence of executables

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 26, 2021
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Nov 26, 2021
kalisp
kalisp approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@iLLiCiTiT iLLiCiTiT merged commit 09272ab into develop Nov 29, 2021
@iLLiCiTiT iLLiCiTiT deleted the feature/validate_binaries_without_executing branch December 13, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalisp kalisp kalisp approved these changes

@antirotor antirotor Awaiting requested review from antirotor

@mkolar mkolar Awaiting requested review from mkolar

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @kalisp