Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fepois: More rigorous tests for separation #457

Open
s3alfisc opened this issue May 30, 2024 · 3 comments
Open

Fepois: More rigorous tests for separation #457

s3alfisc opened this issue May 30, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@s3alfisc
Copy link
Member

Context

In alignment with fixest, pyfixest currently only implements a very basic check for separation.

PyFixest currently implements the most basic separation check, which is equivalent to ppmlhdfe's separation(fe).

Ppmlhdfe implements three more separation checks; it would be nice if fepois() would support some of them.

For a primer on separation, see the primer on separation by the ppmlhdfe team.

To Do:

  • implement additional separation checks for the check_for_separation function.
  • Allow users to specify separation checks via the fepois and Fepois interfaces.
@s3alfisc s3alfisc added enhancement New feature or request good first issue Good for newcomers labels May 30, 2024
@s3alfisc s3alfisc changed the title Implement more rigorous tests for separation in Poisson Regression Fepois: More rigorous tests for separation May 30, 2024
@leostimpfle
Copy link
Contributor

I'd be interested in working on this

@s3alfisc
Copy link
Member Author

s3alfisc commented Jun 7, 2024

Awesome, then I'll assign this issue to it. Maybe we could approach it one separation check at a time, with multiple PRs? This is just a suggestion, I am happy to follow your lead on how to structure the PR(s) =)

@leostimpfle
Copy link
Contributor

leostimpfle commented Jun 7, 2024

Yes, seems sensible to do it method by method. I was thinking of initially focussing on ir (iterative rectifier) because it is recommended in combination with fe for regressions with many high-dimensional fixed effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants