-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "puma-heroku" the default config #1949
Comments
The items in puma/puma-heroku to be moved into lib/puma/configuration.rb could include:
Q: Any these items that have higher priority? A: Not particularly. The list has been updated. |
@olleolleolle Not particularly. I'm think we can omit the 5.2-and-lower database-connecting stuff, as those versions as no longer officially supported.
|
@nateberkopec From memory: I've only used it because the option setting was there, and then used the same values for "max". Merging them into one useful setting: a good thing. |
Also re: Set min and max threads via ENV variable(s): min_threads, max_threads set to Integer(ENV['RAILS_MAX_THREADS'] || ENV['MAX_THREADS'] || 5) (perhaps w/ a RAILS_MIN_THREADS, too?) We should keep the default of 16 on non-MRI platforms - so we should use a new default of 5 on MRI only. |
#2143 might need a hand with this.. having issues repeating failing tests locally. |
Hello! |
The gem is a bit misnamed, it's just "good practices in config". I think we could mainline most of the settings in there for 5.0 and sunset the gem.
The text was updated successfully, but these errors were encountered: