Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Bintray to Sonatype #367

Merged
merged 17 commits into from
Apr 24, 2021

Conversation

karenfeng
Copy link
Collaborator

@karenfeng karenfeng commented Apr 23, 2021

What changes are proposed in this pull request?

As Bintray is being sunsetted shortly, we need a new staging repository. This PR migrates us from sbt-bintray to sbt-sonatype. As Sonatype does not allow downloads from their remote staging repo, we use the local staging repo for our staging tests.

Of note to release conductors:

  • We now use PGP signing. Use gpg --full-generate-key to generate your personal key, and set export GPG_TTY=$(tty).
  • You now need Sonatype account creds in $HOME/sbt/1.0/sonatype.sbt, on which you should run chmod 777. Contact me to get access.
  • To avoid accidental promotions, we will perform manual promotions to Maven Central via the Nexus Repository Manager.

How is this patch tested?

  • Unit tests
  • Integration tests
  • Manual tests

Pushed a staging release and verified that staging tests pass.

Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
This reverts commit 744d865.

Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #367 (9d43e8f) into master (b5fae35) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          95       95           
  Lines        4823     4823           
  Branches      473      473           
=======================================
  Hits         4519     4519           
  Misses        304      304           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5fae35...9d43e8f. Read the comment docs.

Copy link
Collaborator

@kianfar77 kianfar77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Appreciate it.

@karenfeng karenfeng merged commit 3a0ed97 into projectglow:master Apr 24, 2021
@karenfeng karenfeng deleted the sunset-bintray branch April 24, 2021 00:13
@karenfeng karenfeng mentioned this pull request Apr 29, 2021
williambrandler pushed a commit to williambrandler/glow that referenced this pull request Jun 15, 2021
* Bintray to Sonatype

Signed-off-by: Karen Feng <[email protected]>

* release steps

Signed-off-by: Karen Feng <[email protected]>

* Setting version to 1.0.0-sonatypetest

Signed-off-by: Karen Feng <[email protected]>

* Setting stable version to 1.0.0-sonatypetest

Signed-off-by: Karen Feng <[email protected]>

* Tmp

Signed-off-by: Karen Feng <[email protected]>

* publishTo sonatype

Signed-off-by: Karen Feng <[email protected]>

* Add sonatype.sbt

Signed-off-by: Karen Feng <[email protected]>

* add to sonatype.sbt

Signed-off-by: Karen Feng <[email protected]>

* ThisBuild

Signed-off-by: Karen Feng <[email protected]>

* Add sonatype resolver

Signed-off-by: Karen Feng <[email protected]>

* use local staging

Signed-off-by: Karen Feng <[email protected]>

* Prep/upload to sonatype once

Signed-off-by: Karen Feng <[email protected]>

* Combine steps

Signed-off-by: Karen Feng <[email protected]>

* Revert "Setting version to 1.0.0-sonatypetest"

This reverts commit 744d865.

Signed-off-by: Karen Feng <[email protected]>

* Revert "Setting stable version to 1.0.0-sonatypetest"

This reverts commit 3b52a43.

Signed-off-by: Karen Feng <[email protected]>

* Revert unintended changes

Signed-off-by: Karen Feng <[email protected]>

* Trigger tests

Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: William Brandler <[email protected]>
bcajes pushed a commit to bcajes/glow that referenced this pull request Sep 27, 2021
* Bintray to Sonatype

Signed-off-by: Karen Feng <[email protected]>

* release steps

Signed-off-by: Karen Feng <[email protected]>

* Setting version to 1.0.0-sonatypetest

Signed-off-by: Karen Feng <[email protected]>

* Setting stable version to 1.0.0-sonatypetest

Signed-off-by: Karen Feng <[email protected]>

* Tmp

Signed-off-by: Karen Feng <[email protected]>

* publishTo sonatype

Signed-off-by: Karen Feng <[email protected]>

* Add sonatype.sbt

Signed-off-by: Karen Feng <[email protected]>

* add to sonatype.sbt

Signed-off-by: Karen Feng <[email protected]>

* ThisBuild

Signed-off-by: Karen Feng <[email protected]>

* Add sonatype resolver

Signed-off-by: Karen Feng <[email protected]>

* use local staging

Signed-off-by: Karen Feng <[email protected]>

* Prep/upload to sonatype once

Signed-off-by: Karen Feng <[email protected]>

* Combine steps

Signed-off-by: Karen Feng <[email protected]>

* Revert "Setting version to 1.0.0-sonatypetest"

This reverts commit 744d865.

Signed-off-by: Karen Feng <[email protected]>

* Revert "Setting stable version to 1.0.0-sonatypetest"

This reverts commit 3b52a43.

Signed-off-by: Karen Feng <[email protected]>

* Revert unintended changes

Signed-off-by: Karen Feng <[email protected]>

* Trigger tests

Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: brian cajes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants