Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken covariate/phenotype validation #343

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

karenfeng
Copy link
Collaborator

What changes are proposed in this pull request?

Switches to pandas-style verification.

How is this patch tested?

  • Unit tests
  • Integration tests
  • Manual tests

This broke the linreg test in the GWAS notebook I was running as part of a release; this fix resolved the issue.

Signed-off-by: Karen Feng <[email protected]>
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #343 (21d2539) into master (54db807) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          95       95           
  Lines        4823     4823           
  Branches      473      473           
=======================================
  Hits         4519     4519           
  Misses        304      304           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54db807...21d2539. Read the comment docs.

@karenfeng karenfeng merged commit 572a1b3 into projectglow:master Feb 5, 2021
@karenfeng karenfeng deleted the fix-pandas-check branch February 5, 2021 20:47
bcajes pushed a commit to bcajes/glow that referenced this pull request Sep 27, 2021
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: brian cajes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants