Fix IntelliJ import #223
Merged
Fix IntelliJ import #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP Signed-off-by: Karen Feng <[email protected]> * Ndarray Signed-off-by: Karen Feng <[email protected]> * More tests Signed-off-by: Karen Feng <[email protected]> * Support flat array Signed-off-by: Karen Feng <[email protected]> * Move registering Signed-off-by: Karen Feng <[email protected]> * pytest Signed-off-by: Karen Feng <[email protected]> * Make docstring more accurate Signed-off-by: Karen Feng <[email protected]> * idempotent registration Signed-off-by: Karen Feng <[email protected]> * Test fixup Signed-off-by: Karen Feng <[email protected]> * Move import out Signed-off-by: Karen Feng <[email protected]>
* doc Signed-off-by: kianfar77 <[email protected]> * doc Signed-off-by: kianfar77 <[email protected]> * notebook Signed-off-by: kianfar77 <[email protected]> * attributes Signed-off-by: kianfar77 <[email protected]> * yapf Signed-off-by: kianfar77 <[email protected]> Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
karenfeng
force-pushed
the
cross-build-env-vars
branch
from
4133fb0
to
dbc6459
Compare
…ss-build-env-vars Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Karen Feng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 88 88
Lines 4232 4232
Branches 359 359
=======================================
Hits 3961 3961
Misses 271 271 Continue to review full report at Codecov.
|
henrydavidge
reviewed
Jun 1, 2020
Signed-off-by: Karen Feng <[email protected]>
henrydavidge
pushed a commit
to henrydavidge/glow
that referenced
this pull request
Jun 2, 2020
* Support numpy literals (projectglow#213) * WIP Signed-off-by: Karen Feng <[email protected]> * Ndarray Signed-off-by: Karen Feng <[email protected]> * More tests Signed-off-by: Karen Feng <[email protected]> * Support flat array Signed-off-by: Karen Feng <[email protected]> * Move registering Signed-off-by: Karen Feng <[email protected]> * pytest Signed-off-by: Karen Feng <[email protected]> * Make docstring more accurate Signed-off-by: Karen Feng <[email protected]> * idempotent registration Signed-off-by: Karen Feng <[email protected]> * Test fixup Signed-off-by: Karen Feng <[email protected]> * Move import out Signed-off-by: Karen Feng <[email protected]> * Add documentation for the GFF3 reader (projectglow#221) * doc Signed-off-by: kianfar77 <[email protected]> * doc Signed-off-by: kianfar77 <[email protected]> * notebook Signed-off-by: kianfar77 <[email protected]> * attributes Signed-off-by: kianfar77 <[email protected]> * yapf Signed-off-by: kianfar77 <[email protected]> Signed-off-by: Karen Feng <[email protected]> * Remove cross-build plugin Signed-off-by: Karen Feng <[email protected]> * wrap Signed-off-by: Karen Feng <[email protected]> * triple quote Signed-off-by: Karen Feng <[email protected]> * set 'for imports' and 'for builds' within sbt settings Signed-off-by: Karen Feng <[email protected]> * CircleCI config Signed-off-by: Karen Feng <[email protected]> * wrap release Signed-off-by: Karen Feng <[email protected]> * More docs Signed-off-by: Karen Feng <[email protected]> * Comments Signed-off-by: Karen Feng <[email protected]> Co-authored-by: Kiavash Kianfar <[email protected]>
henrydavidge
added a commit
that referenced
this pull request
Jun 2, 2020
* Support numpy literals (#213) * WIP Signed-off-by: Karen Feng <[email protected]> * Ndarray Signed-off-by: Karen Feng <[email protected]> * More tests Signed-off-by: Karen Feng <[email protected]> * Support flat array Signed-off-by: Karen Feng <[email protected]> * Move registering Signed-off-by: Karen Feng <[email protected]> * pytest Signed-off-by: Karen Feng <[email protected]> * Make docstring more accurate Signed-off-by: Karen Feng <[email protected]> * idempotent registration Signed-off-by: Karen Feng <[email protected]> * Test fixup Signed-off-by: Karen Feng <[email protected]> * Move import out Signed-off-by: Karen Feng <[email protected]> * Add documentation for the GFF3 reader (#221) * doc Signed-off-by: kianfar77 <[email protected]> * doc Signed-off-by: kianfar77 <[email protected]> * notebook Signed-off-by: kianfar77 <[email protected]> * attributes Signed-off-by: kianfar77 <[email protected]> * yapf Signed-off-by: kianfar77 <[email protected]> Signed-off-by: Karen Feng <[email protected]> * Remove cross-build plugin Signed-off-by: Karen Feng <[email protected]> * wrap Signed-off-by: Karen Feng <[email protected]> * triple quote Signed-off-by: Karen Feng <[email protected]> * set 'for imports' and 'for builds' within sbt settings Signed-off-by: Karen Feng <[email protected]> * CircleCI config Signed-off-by: Karen Feng <[email protected]> * wrap release Signed-off-by: Karen Feng <[email protected]> * new rule Signed-off-by: Henry D <[email protected]> * Support numpy literals (#213) * WIP Signed-off-by: Karen Feng <[email protected]> * Ndarray Signed-off-by: Karen Feng <[email protected]> * More tests Signed-off-by: Karen Feng <[email protected]> * Support flat array Signed-off-by: Karen Feng <[email protected]> * Move registering Signed-off-by: Karen Feng <[email protected]> * pytest Signed-off-by: Karen Feng <[email protected]> * Make docstring more accurate Signed-off-by: Karen Feng <[email protected]> * idempotent registration Signed-off-by: Karen Feng <[email protected]> * Test fixup Signed-off-by: Karen Feng <[email protected]> * Move import out Signed-off-by: Karen Feng <[email protected]> * Add documentation for the GFF3 reader (#221) * doc Signed-off-by: kianfar77 <[email protected]> * doc Signed-off-by: kianfar77 <[email protected]> * notebook Signed-off-by: kianfar77 <[email protected]> * attributes Signed-off-by: kianfar77 <[email protected]> * yapf Signed-off-by: kianfar77 <[email protected]> * More docs Signed-off-by: Karen Feng <[email protected]> * add tests Signed-off-by: Henry D <[email protected]> * style Signed-off-by: Henry D <[email protected]> * Fix IntelliJ import (#223) * Support numpy literals (#213) * WIP Signed-off-by: Karen Feng <[email protected]> * Ndarray Signed-off-by: Karen Feng <[email protected]> * More tests Signed-off-by: Karen Feng <[email protected]> * Support flat array Signed-off-by: Karen Feng <[email protected]> * Move registering Signed-off-by: Karen Feng <[email protected]> * pytest Signed-off-by: Karen Feng <[email protected]> * Make docstring more accurate Signed-off-by: Karen Feng <[email protected]> * idempotent registration Signed-off-by: Karen Feng <[email protected]> * Test fixup Signed-off-by: Karen Feng <[email protected]> * Move import out Signed-off-by: Karen Feng <[email protected]> * Add documentation for the GFF3 reader (#221) * doc Signed-off-by: kianfar77 <[email protected]> * doc Signed-off-by: kianfar77 <[email protected]> * notebook Signed-off-by: kianfar77 <[email protected]> * attributes Signed-off-by: kianfar77 <[email protected]> * yapf Signed-off-by: kianfar77 <[email protected]> Signed-off-by: Karen Feng <[email protected]> * Remove cross-build plugin Signed-off-by: Karen Feng <[email protected]> * wrap Signed-off-by: Karen Feng <[email protected]> * triple quote Signed-off-by: Karen Feng <[email protected]> * set 'for imports' and 'for builds' within sbt settings Signed-off-by: Karen Feng <[email protected]> * CircleCI config Signed-off-by: Karen Feng <[email protected]> * wrap release Signed-off-by: Karen Feng <[email protected]> * More docs Signed-off-by: Karen Feng <[email protected]> * Comments Signed-off-by: Karen Feng <[email protected]> Co-authored-by: Kiavash Kianfar <[email protected]> * comments Signed-off-by: Henry D <[email protected]> * more docs Signed-off-by: Henry D <[email protected]> * note pr Signed-off-by: Henry D <[email protected]> Co-authored-by: Karen Feng <[email protected]> Co-authored-by: Kiavash Kianfar <[email protected]>
henrydavidge
pushed a commit
to henrydavidge/glow
that referenced
this pull request
Jun 22, 2020
* Support numpy literals (projectglow#213) * WIP Signed-off-by: Karen Feng <[email protected]> * Ndarray Signed-off-by: Karen Feng <[email protected]> * More tests Signed-off-by: Karen Feng <[email protected]> * Support flat array Signed-off-by: Karen Feng <[email protected]> * Move registering Signed-off-by: Karen Feng <[email protected]> * pytest Signed-off-by: Karen Feng <[email protected]> * Make docstring more accurate Signed-off-by: Karen Feng <[email protected]> * idempotent registration Signed-off-by: Karen Feng <[email protected]> * Test fixup Signed-off-by: Karen Feng <[email protected]> * Move import out Signed-off-by: Karen Feng <[email protected]> * Add documentation for the GFF3 reader (projectglow#221) * doc Signed-off-by: kianfar77 <[email protected]> * doc Signed-off-by: kianfar77 <[email protected]> * notebook Signed-off-by: kianfar77 <[email protected]> * attributes Signed-off-by: kianfar77 <[email protected]> * yapf Signed-off-by: kianfar77 <[email protected]> Signed-off-by: Karen Feng <[email protected]> * Remove cross-build plugin Signed-off-by: Karen Feng <[email protected]> * wrap Signed-off-by: Karen Feng <[email protected]> * triple quote Signed-off-by: Karen Feng <[email protected]> * set 'for imports' and 'for builds' within sbt settings Signed-off-by: Karen Feng <[email protected]> * CircleCI config Signed-off-by: Karen Feng <[email protected]> * wrap release Signed-off-by: Karen Feng <[email protected]> * More docs Signed-off-by: Karen Feng <[email protected]> * Comments Signed-off-by: Karen Feng <[email protected]> Co-authored-by: Kiavash Kianfar <[email protected]> Signed-off-by: Henry Davidge <[email protected]>
henrydavidge
added a commit
to henrydavidge/glow
that referenced
this pull request
Jun 22, 2020
* Support numpy literals (projectglow#213) * WIP Signed-off-by: Karen Feng <[email protected]> * Ndarray Signed-off-by: Karen Feng <[email protected]> * More tests Signed-off-by: Karen Feng <[email protected]> * Support flat array Signed-off-by: Karen Feng <[email protected]> * Move registering Signed-off-by: Karen Feng <[email protected]> * pytest Signed-off-by: Karen Feng <[email protected]> * Make docstring more accurate Signed-off-by: Karen Feng <[email protected]> * idempotent registration Signed-off-by: Karen Feng <[email protected]> * Test fixup Signed-off-by: Karen Feng <[email protected]> * Move import out Signed-off-by: Karen Feng <[email protected]> * Add documentation for the GFF3 reader (projectglow#221) * doc Signed-off-by: kianfar77 <[email protected]> * doc Signed-off-by: kianfar77 <[email protected]> * notebook Signed-off-by: kianfar77 <[email protected]> * attributes Signed-off-by: kianfar77 <[email protected]> * yapf Signed-off-by: kianfar77 <[email protected]> Signed-off-by: Karen Feng <[email protected]> * Remove cross-build plugin Signed-off-by: Karen Feng <[email protected]> * wrap Signed-off-by: Karen Feng <[email protected]> * triple quote Signed-off-by: Karen Feng <[email protected]> * set 'for imports' and 'for builds' within sbt settings Signed-off-by: Karen Feng <[email protected]> * CircleCI config Signed-off-by: Karen Feng <[email protected]> * wrap release Signed-off-by: Karen Feng <[email protected]> * new rule Signed-off-by: Henry D <[email protected]> * Support numpy literals (projectglow#213) * WIP Signed-off-by: Karen Feng <[email protected]> * Ndarray Signed-off-by: Karen Feng <[email protected]> * More tests Signed-off-by: Karen Feng <[email protected]> * Support flat array Signed-off-by: Karen Feng <[email protected]> * Move registering Signed-off-by: Karen Feng <[email protected]> * pytest Signed-off-by: Karen Feng <[email protected]> * Make docstring more accurate Signed-off-by: Karen Feng <[email protected]> * idempotent registration Signed-off-by: Karen Feng <[email protected]> * Test fixup Signed-off-by: Karen Feng <[email protected]> * Move import out Signed-off-by: Karen Feng <[email protected]> * Add documentation for the GFF3 reader (projectglow#221) * doc Signed-off-by: kianfar77 <[email protected]> * doc Signed-off-by: kianfar77 <[email protected]> * notebook Signed-off-by: kianfar77 <[email protected]> * attributes Signed-off-by: kianfar77 <[email protected]> * yapf Signed-off-by: kianfar77 <[email protected]> * More docs Signed-off-by: Karen Feng <[email protected]> * add tests Signed-off-by: Henry D <[email protected]> * style Signed-off-by: Henry D <[email protected]> * Fix IntelliJ import (projectglow#223) * Support numpy literals (projectglow#213) * WIP Signed-off-by: Karen Feng <[email protected]> * Ndarray Signed-off-by: Karen Feng <[email protected]> * More tests Signed-off-by: Karen Feng <[email protected]> * Support flat array Signed-off-by: Karen Feng <[email protected]> * Move registering Signed-off-by: Karen Feng <[email protected]> * pytest Signed-off-by: Karen Feng <[email protected]> * Make docstring more accurate Signed-off-by: Karen Feng <[email protected]> * idempotent registration Signed-off-by: Karen Feng <[email protected]> * Test fixup Signed-off-by: Karen Feng <[email protected]> * Move import out Signed-off-by: Karen Feng <[email protected]> * Add documentation for the GFF3 reader (projectglow#221) * doc Signed-off-by: kianfar77 <[email protected]> * doc Signed-off-by: kianfar77 <[email protected]> * notebook Signed-off-by: kianfar77 <[email protected]> * attributes Signed-off-by: kianfar77 <[email protected]> * yapf Signed-off-by: kianfar77 <[email protected]> Signed-off-by: Karen Feng <[email protected]> * Remove cross-build plugin Signed-off-by: Karen Feng <[email protected]> * wrap Signed-off-by: Karen Feng <[email protected]> * triple quote Signed-off-by: Karen Feng <[email protected]> * set 'for imports' and 'for builds' within sbt settings Signed-off-by: Karen Feng <[email protected]> * CircleCI config Signed-off-by: Karen Feng <[email protected]> * wrap release Signed-off-by: Karen Feng <[email protected]> * More docs Signed-off-by: Karen Feng <[email protected]> * Comments Signed-off-by: Karen Feng <[email protected]> Co-authored-by: Kiavash Kianfar <[email protected]> * comments Signed-off-by: Henry D <[email protected]> * more docs Signed-off-by: Henry D <[email protected]> * note pr Signed-off-by: Henry D <[email protected]> Co-authored-by: Karen Feng <[email protected]> Co-authored-by: Kiavash Kianfar <[email protected]> Signed-off-by: Henry Davidge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The existing cross-build functionality does not work well with IntelliJ. To fix this and simplify the build, I changed our cross-build setup to set the Scala version via an environment variable
SCALA_VERSION. The user will have to change their SBT settings according to the README.As a result, the
core_2_11andcore_2_12projects no longer exist; the Scala base project is accessed viacorewith the appropriate env var. To make this compatible with the release process, we toggle thescalaVersionSBT settingKey before running the full suites of tests.How is this patch tested?