Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use full ExpressionInfo constructor (#209)" #214

Merged

Conversation

karenfeng
Copy link
Collaborator

What changes are proposed in this pull request?

This reverts commit 6bf8435.

How is this patch tested?

  • Unit tests
  • Integration tests
  • Manual tests

Copy link
Contributor

@henrydavidge henrydavidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #214 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files          88       88           
  Lines        4229     4229           
  Branches      368      368           
=======================================
  Hits         3958     3958           
  Misses        271      271           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed6097b...3aca5b9. Read the comment docs.

@karenfeng karenfeng merged commit 14e42ec into projectglow:master May 19, 2020
@karenfeng karenfeng deleted the revert-expression-info-change branch May 19, 2020 17:50
henrydavidge pushed a commit to henrydavidge/glow that referenced this pull request Jun 22, 2020
…ctglow#214)

This reverts commit 6bf8435.

Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Henry Davidge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants