Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PLINK documentation #210

Merged
merged 1 commit into from
May 14, 2020
Merged

Conversation

karenfeng
Copy link
Collaborator

What changes are proposed in this pull request?

The PLINK documentation is currently incorrect - we assume FAM files are delimited by spaces and BIM by tab, not the other way around.

How is this patch tested?

  • Unit tests
  • Integration tests
  • Manual tests

(Details)

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #210 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          86       86           
  Lines        4185     4185           
  Branches      367      367           
=======================================
  Hits         3921     3921           
  Misses        264      264           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f5678...d6191dc. Read the comment docs.

Copy link
Contributor

@henrydavidge henrydavidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karenfeng karenfeng merged commit 23dbc32 into projectglow:master May 14, 2020
@karenfeng karenfeng deleted the fix-plink-docs branch May 14, 2020 17:34
henrydavidge pushed a commit to henrydavidge/glow that referenced this pull request Jun 22, 2020
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Henry Davidge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants