Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbus-connection.c issue #46

Closed
Aiexis opened this issue Sep 1, 2013 · 17 comments
Closed

dbus-connection.c issue #46

Aiexis opened this issue Sep 1, 2013 · 17 comments

Comments

@Aiexis
Copy link

Aiexis commented Sep 1, 2013

Hello
I get an error in loop while launching any media file
process 2705: arguments to dbus_connection_read_write_dispatch() were incorrect, assertion "connection != NULL" failed in file ../../dbus/dbus-connection.c line 3727.
This is normally a bug in some application using the D-Bus library.
(idem with line 4363)

The file is correctly played anyway, but no hot-key action is enabled.
$ omxplayer -v
omxplayer - Commandline multimedia player for the Raspberry Pi
Build date: Sun, 01 Sep 2013 14:07:59 +0200
Version : 5c886fa [master]

Thank you.

@popcornmix
Copy link
Owner

@quom any thoughts?

@tvjon
Copy link

tvjon commented Sep 1, 2013

Hello,

same problems for me, dbus & no keys recognised. Additionally, DVB recordings (Transport Streams) are unwatchable owing to random, but frequent stuttering.

@skgsergio
Copy link

Built a new version. I've deleted the previous build.

I can't test this till this evening.

@Aiexis
Copy link
Author

Aiexis commented Sep 3, 2013

at start
/usr/bin/omxplayer: line 43: dbus-launch: command not found

And still no keys.

@tvjon
Copy link

tvjon commented Sep 3, 2013

Hello Sergio, thank you for the update.

Keyboard control now back, no console error messages, DVB Transport Streams seem to be ok on a short test, & interestingly I can now pause a http:// stream.

Alexis, it seems strange you see no improvement. Can you provide any further information?
After my brief tests I checked the version just to be sure:

pi@raspicam ~/downloads $ omxplayer -v
omxplayer - Commandline multimedia player for the Raspberry Pi
Build date: Tue, 03 Sep 2013 12:22:01 +0200
Version : 40bf71e [master]
Repository: https://github.com/popcornmix/omxplayer.git

@quom
Copy link

quom commented Sep 3, 2013

Stuttering playback was caused by error messages in the main loop preventing playback, which were caused by the keyboard errors.

Aiexis, it seems the launch script can't find the dbus-launch application. This is installed by default on raspbian so if you could locate it and change the command to the absolute path in the omxplayer script this should fix the problem (it's located at /usr/bin/dbus-launch on mine).

@Aiexis
Copy link
Author

Aiexis commented Sep 3, 2013

/usr/bin/dbus-launch doesn't exist on my Raspbian. May be I have uninstalled this (don't know when, and why...)
How can I reinstall it ? Google is not very helpful.

@popcornmix
Copy link
Owner

Does:
sudo apt-get install dbus
fix it?

@Aiexis
Copy link
Author

Aiexis commented Sep 3, 2013

No.
"dbus is already the newest version.

Also tried to install qdbus and dbus-x11.

@Aiexis
Copy link
Author

Aiexis commented Sep 3, 2013

Hmmm... now it works, even if /usr/bin/dbus-launch still doesn't exist.
Installation of qbus and/or dbus-x11 has fixed problem (no more error message and hotkeys works again).

@quom
Copy link

quom commented Sep 3, 2013

I think if X is running then the dbus session daemon will already be running, in which case the dbus-launch program is not needed.

@Aiexis
Copy link
Author

Aiexis commented Sep 3, 2013

X is not running in my Pi.

I need to install the packages dbus-x11.
Now it works perfectly.
EDIT: or not... omxplayer uses FAR more CPU ! (95% against 30% on the same video file for any previous version)

@quom
Copy link

quom commented Sep 3, 2013

Yes it looks as though dbus-x11 is required for the dbus-launch program.

@skgsergio
Copy link

Ok, dbus-launch came from dbus-x11 so I'll be adding it to the deps.
http://packages.debian.org/search?searchon=contents&keywords=dbus-launch

On the other hand I'll try to make a debug build and analyze it with a profiler to have a look into the CPU usage. (don't know when, I'm kinda busy this week).

@skgsergio skgsergio mentioned this issue Sep 3, 2013
@tvjon
Copy link

tvjon commented Sep 3, 2013

Quom, thank you for that. It always helps to know why these things occur.

"Stuttering playback was caused by error messages in the main loop preventing playback, which were caused by the keyboard errors."

@quom
Copy link

quom commented Sep 3, 2013

I'll also take a look at the CPU usage issue.

I suspect it is due to the polling nature of the main event loop which causes it. The more conventional asynchronous approach with timeouts would probably solve this although it would require a complete rewrite of how the main loop deals with events.

@skgsergio
Copy link

Lets discuss the CPU usage at #48 I'll be posting some info there soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants