-
-
Notifications
You must be signed in to change notification settings - Fork 278
Conversation
|
||
install: | ||
- yarn install | ||
- yarn run rebuild:modules:electron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarzzz - are these still the correct commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chriddyp Yep, these should work.
|
||
script: | ||
- yarn run build | ||
- yarn run package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to make sure that this branch's package.js
contains the exception for mac: https://github.com/plotly/falcon-sql-client/blob/master/package.js#L67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the relevant issue in case you want to go into details: ibmdb/node-ibm_db#329
Nice.. working builds.. 💃 |
based loosely off of https://github.com/develar/onshape-desktop-shell/blob/46aa06803f78a66871 058f717249134ab1fdc341/.travis.yml
right now `zip` displays every single line that it’s zipping, which is huge since it’s every file in `node_modules`
Only [email protected] seems to work for builds
c3d0e63
to
a397a71
Compare
@chriddyp Attempted to fix the failing build + added command to create I cannot examine builds because I do not seem to have 'download' access to the S3 bucket (Using |
@tarzzz - Try visiting this link: https://s3.amazonaws.com/falcon-travis-artifacts - You'll see a list of the keys in the bucket and will be able to follow them to get the download link, e.g. https://s3.amazonaws.com/falcon-travis-artifacts/plotly/falcon-sql-client/46/46.1/release.zip. I believe that I've made this publicly world-readable. |
@chriddyp Seems to be some issue with the permissions in S3 bucket: FWIW, I can download older releases (i.e |
Update: @cldougl Checked the uploaded binaries with her account, but the builds are still failing with the same error. |
Thanks for reporting! I just modified the S3 policy again, everything should be public-readable now. |
console.warn('An error occured:' + stderr); | ||
return; | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chriddyp ibmdb/node-ibm_db#329 hasn't been fixed inibm_db
yet.
Brought to you by Travis CI and uploaded to S3.
Unfortunately, doesn't quite work yet, but it's close: