Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Mac builds #205

Merged
merged 13 commits into from
Oct 27, 2017
Merged

Mac builds #205

merged 13 commits into from
Oct 27, 2017

Conversation

chriddyp
Copy link
Member

Brought to you by Travis CI and uploaded to S3.

Unfortunately, doesn't quite work yet, but it's close:
image


install:
- yarn install
- yarn run rebuild:modules:electron
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarzzz - are these still the correct commands?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chriddyp Yep, these should work.


script:
- yarn run build
- yarn run package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to make sure that this branch's package.js contains the exception for mac: https://github.com/plotly/falcon-sql-client/blob/master/package.js#L67

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the relevant issue in case you want to go into details: ibmdb/node-ibm_db#329

@tarzzz
Copy link
Contributor

tarzzz commented Oct 24, 2017

Nice.. working builds.. 💃

@chriddyp
Copy link
Member Author

Nice.. working builds.. 💃

Unfortunately, they don't work yet! Getting this error for some reason, I'm not sure why.
image

@tarzzz tarzzz force-pushed the mac-builds branch 2 times, most recently from c3d0e63 to a397a71 Compare October 25, 2017 11:30
@tarzzz
Copy link
Contributor

tarzzz commented Oct 25, 2017

@chriddyp Attempted to fix the failing build + added command to create dmg and upload it to S3..

I cannot examine builds because I do not seem to have 'download' access to the S3 bucket (Using Plotly_Editors account)..

@chriddyp
Copy link
Member Author

chriddyp commented Oct 25, 2017

@tarzzz - Try visiting this link: https://s3.amazonaws.com/falcon-travis-artifacts - You'll see a list of the keys in the bucket and will be able to follow them to get the download link, e.g. https://s3.amazonaws.com/falcon-travis-artifacts/plotly/falcon-sql-client/46/46.1/release.zip. I believe that I've made this publicly world-readable.

@tarzzz
Copy link
Contributor

tarzzz commented Oct 26, 2017

@chriddyp Seems to be some issue with the permissions in S3 bucket:
image

FWIW, I can download older releases (i.e 48.1 etc.), but not the latest (68.1)

@tarzzz
Copy link
Contributor

tarzzz commented Oct 27, 2017

Update: @cldougl Checked the uploaded binaries with her account, but the builds are still failing with the same error.

@chriddyp
Copy link
Member Author

FWIW, I can download older releases (i.e 48.1 etc.), but not the latest (68.1)

Thanks for reporting! I just modified the S3 policy again, everything should be public-readable now.

@chriddyp
Copy link
Member Author

builds are working now! 🎉
image

console.warn('An error occured:' + stderr);
return;
}
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarzzz @n-riesco - I still don't understand why we have to do this - I thought that this was done in the ibmdb2 library now? In any case, this was the required piece to make builds work on travis.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chriddyp ibmdb/node-ibm_db#329 hasn't been fixed inibm_db yet.

@chriddyp chriddyp merged commit 915eb28 into master Oct 27, 2017
@chriddyp chriddyp deleted the mac-builds branch October 27, 2017 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants