-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple supp IDVAR values going to the same QNAM adds multiple IDVAR.x, .y, etc columns #63
Comments
As I was working on this PR, I found this test that I don't understand. I thought that the intent of metatools/tests/testthat/test-supp.R Lines 154 to 183 in d3a5642
I would have thought that the preferred behavior would have been:
And, step 3 above should account for repeated I'm going to make the PR change the behavior to add column names that are not identical to the QNAM name because that seems to be more accurate for the SDTM standard, and this will be a breaking change. I'm happy to chat about it if there is a reason to keep the current behavior. |
In the example below, there should be a single "AETERM" column not an "AETERM.x" and "AETERM.y" column.
Created on 2024-04-12 with reprex v2.1.0
I'm working on a PR for this now.
The text was updated successfully, but these errors were encountered: