Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: peterbourgon/ff
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.3.0
Choose a base ref
...
head repository: peterbourgon/ff
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.4.0
Choose a head ref
  • 6 commits
  • 20 files changed
  • 3 contributors

Commits on Nov 22, 2022

  1. Update deprecated func in README example (#102)

    WithEnvVarNoPrefix() (Deprecated) -> WithEnvVars()
    gilcrest committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    fe611a8 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. ffcli.DefaultUsageFunc: Support flag help placeholders (#106)

    (This is an arguably uncontroversial part of the proposal in #105.
    Its's a new feature, not a significant change in behavior.)
    
    Currently, ffcli.DefaultUsageFunc prints "..." for any flag
    that does not have a default value specified.
    This produces less-than-effective help from DefaultUsageFunc.
    
    This change retains the behavior of printing the default value as-is,
    but if a default value is not provided,
    it allows users to provide placeholder text
    by wrapping a word inside the help text for a flag in backticks.
    
    For example, given the following:
    
        fset.String("c", "" /* default */, "path to `config` file")
    
    We'll get:
    
        -c config  path to config file
    
    This matches the behavior of FlagSet.PrintDefaults,
    and indeed it relies on the same flag.UnquoteUsage machinery for this.
    
    This also has the nice side-effect of making a reasonable guess
    at an alternative placeholder text instead of "...". For example:
    
        fset.Int("n", "" /* default */, "number of items")
    
        // Before: -n ...  number of items
        // Now:    -n int  number of items
    
    Note that as implemented right now, the user supplied placeholder will
    be used only if a non-zero default value was not supplied.
    This was an attempt to retain as much of the existing behavior.
    The proposal in #105, if you're open to it,
    would change more of the output.
    abhinav committed May 9, 2023
    Configuration menu
    Copy the full SHA
    61fa353 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. WithFilesystem (#110)

    * WithFilesystem
    
    * configFileLookup was unused
    
    * options.go was unused
    
    * json[_test].go -> json_parser[_test].go
    peterbourgon committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    c76f02c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a98a914 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. ffcli: add DESCRIPTION with Shorthelp to DefaultUsageFunc (#111)

    * ffcli: DefaultUsageFunc: add DESCRIPTION with ShortHelp
    
    * ffcli: fix tests
    peterbourgon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    858a455 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. JSON, TOML, YAML: support for nested config data (#112)

    * internal: add TraverseMap
    
    * gofumpt
    
    * JSONParseConfig
    
    * internal: TraverseMap: map[any]any
    
    * fftoml: don't break the API
    
    * internal: TraverseMap: test for map[any]any
    
    * fftest, ffyaml: nested node tests
    
    * Can't remove ParseError types
    
    * Can't remove StringConversionError type
    peterbourgon committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    e267c41 View commit details
    Browse the repository at this point in the history
Loading