[BACKLOG-26517] Adding Password to ExcelInput dialog

[ccaspanello]

No description provided.

[wingman-pentaho]

Build Completed

❌ This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -f 'pom.xml' -pl 'ui,engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install
mvn -B -f 'integration/pom.xml' -pl '.' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands

mvn -B -f 'pom.xml' -pl 'ui,engine' -P '!assemblies' -amd build-helper:remove-project-artifact && mvn -B -f 'integration/pom.xml' -pl '.' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files

  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/ExcelInput.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/ExcelInputMeta.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/WorkbookFactory.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/poi/PoiWorkbook.java
  engine/src/main/resources/org/pentaho/di/trans/steps/excelinput/messages/messages_en_US.properties
  engine/src/test/java/org/pentaho/di/trans/steps/excelinput/ExcelInputMetaTest.java
  integration/src/it/java/org/pentaho/di/trans/steps/excelinput/PoiWorkBookIT.java
  integration/src/it/java/org/pentaho/di/trans/steps/excelinput/StaxWorkBookIT.java
  integration/src/it/resources/sample-file-protected.xls
  integration/src/it/resources/sample-file-protected.xlsx
  integration/src/it/resources/sample-file.xls
  ui/src/main/java/org/pentaho/di/ui/trans/steps/excelinput/ExcelInputDialog.java
  ui/src/test/java/org/pentaho/di/ui/util/EngineMetaUtilsTest.java

Newly Broken Tests:

org.pentaho.di.trans.step.mqtt.MQTTStreamSourceTest.testMultipleTopics:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError
	at org.pentaho.di.trans.step.mqtt.MQTTStreamSourceTest.getQuickly(MQTTStreamSourceTest.java:253)
	at org.pentaho.di.trans.step.mqtt.MQTTStreamSourceTest.testMultipleTopics(MQTTStreamSourceTest.java:141)

Unit Test Coverage

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

⚠️ Coverage Changes (click to expand)

org.pentaho.di.job.entries.getpop.MailConnectionMeta

• Branch Change: -1% 🔻
• Complexity Change: -1.5% 🔻
• Instruction Change: -0.3% 🔻

org.pentaho.di.trans.steps.excelinput.ExcelInputMeta

• Method Change: -0.3% 🔻

org.pentaho.di.trans.steps.excelinput.poi.PoiWorkbook

• Complexity Change: -1.5% 🔻
• Instruction Change: -4.3% 🔻
• Line Change: -3.6% 🔻
• Method Change: -3.6% 🔻

org.pentaho.di.trans.steps.sort.SortRowsMeta

• Instruction Change: -0.1% 🔻

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

• Branch Change: -0.5% 🔻

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

• Instruction Change: -0.2% 🔻

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

• Instruction Change: -0.1% 🔻

org.pentaho.di.ui.trans.steps.excelinput.ExcelInputDialog

• Branch Change: -0.1% 🔻

[baudekin]

Fix unit tests.