Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Change Pool API to have separate methods for JoinPool and JoinPoolNoSwap #2128

Closed
6 tasks
ValarDragon opened this issue Jul 18, 2022 · 0 comments · Fixed by #2133
Closed
6 tasks
Assignees
Milestone

Comments

@ValarDragon
Copy link
Member

Background

Currently we have a single JoinPool and CalcJoinPoolShares method on the pool API. Something thats become quite clear in #2126 , is that this is terrible for client side users right now, and we need to split the AMM interface to have JoinPool and JoinPoolNoSwap OR make JoinPool just implement the no swap side.

I'm in preference of separating the go API, seeing as we already separate the proto API for messages.

At the moment, theres no clean way to estimate the JoinPoolNoSwap share amount out. IDK what the CLI does here, and I think theres no real way for other users to get the right numbers on multi-asset joins.

Suggested Design

Acceptance Criteria

  • We've improved the JoinPoolNoSwap API so that we can in golang easily estimate it, and delete that function in the simulator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants