Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for X-Forwarded-Proto header #638

Merged
merged 1 commit into from
Feb 15, 2021
Merged

feat: Add support for X-Forwarded-Proto header #638

merged 1 commit into from
Feb 15, 2021

Conversation

christian-roggia
Copy link
Contributor

Related issue

#153 @aeneasr @Entrio

Proposed changes

Add basic support for the header X-Forwarded-Proto which is normally set by an edge proxy like Ambassador, Istio, Traefik, Envoy, etc.

The proposed changes affect only the decision API as it is expected to be contacted by another proxy which will take care of SSL termination in most cases. It is important to notice that even if traffic reaching oathkeeper is plain HTTP, it does not mean that the traffic is not encrypted in transit. A good example is service mesh where Envoy or similar technologies (e.g. Linkerd) will secure traffic in transit through sidecars and mTLS.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

The changes proposed here have been tested in our development environment and they work like a charm for both proper rules matching and redirection URLs.

@christian-roggia christian-roggia changed the title Add support for X-Forwarded-Proto header feat: Add support for X-Forwarded-Proto header Feb 13, 2021
@Entrio
Copy link

Entrio commented Feb 13, 2021

Awesome! Are you sure it was as simple as just that one line? @aeneasr comments?

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants