Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Configurable API server timeout #440

Merged
merged 1 commit into from
May 23, 2020
Merged

feat: Configurable API server timeout #440

merged 1 commit into from
May 23, 2020

Conversation

imranismail
Copy link
Contributor

@imranismail imranismail commented May 18, 2020 •
edited
Loading

Proposed changes

Allows API server timeout to be configured

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@CLAassistant
Copy link

CLAassistant commented May 18, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aeneasr aeneasr marked this pull request as ready for review May 18, 2020 08:32
@aeneasr
Copy link
Member

aeneasr commented May 18, 2020

This looks good to me!

aeneasr
aeneasr reviewed May 18, 2020
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Overall this looks great, I just have some ideas how to improve it further!

driver/configuration/provider_viper.go Outdated Show resolved Hide resolved
driver/configuration/provider_viper.go Outdated Show resolved Hide resolved
driver/configuration/provider_viper.go Outdated Show resolved Hide resolved
.schema/config.schema.json Show resolved Hide resolved
.schemas/config.schema.json Outdated Show resolved Hide resolved
@imranismail imranismail force-pushed the feature/configurable-api-timeout branch from 0874c5d to 6876a92 Compare May 20, 2020 08:27
@imranismail imranismail requested a review from aeneasr May 20, 2020 08:27
@imranismail imranismail force-pushed the feature/configurable-api-timeout branch from 6876a92 to 48407a8 Compare May 20, 2020 08:28
@imranismail imranismail changed the title Configurable API server timeout feat: Configurable API server timeout May 20, 2020
@aeneasr
Copy link
Member

aeneasr commented May 23, 2020

Thank you!

@aeneasr aeneasr merged commit 0dc6292 into ory:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imranismail @CLAassistant @aeneasr