Initial PHP 8 Support

[deleugpn]

Provide PHP 8 Support.

[GrahamCampbell]

Thanks for the PR. I've left some feedback.

[GrahamCampbell]

@sorinsarca Is there any reason we don't include array, iterable, callable in the list of builtin types? I think certainly iterable should be in there?

[sorinsarca]

@GrahamCampbell all should be there, I don't know why they are missing

[GrahamCampbell]

// cc @driesvints for review

[terabytesoftw]

hi, this will merge soon thanks, great Job.

[deleugpn]

Sorry for the delay, this was so much harder than I thought it would be. I finally got all existing tests passing.

I added some new test files during the development process because it was much easier for me to understand the array of tokens with a smaller file. I was pretty much running it on PHP 7.4 and 8.0 and trying to identify different tokens. Let me know if I should revert the new phpunit test files.

I'm not sure what to do with these: https://github.com/opis/closure/pull/67/files#diff-4e781872947f7a06b71197212fc075bcR46
I only took inspiration from Nikita's parser to define the tokens when they don't exist.

Also let me know about the new parser, instead of causing conflict I can try to reimplement. If the new parser is easier to work with, I might be able to use some of the knowledge I gathered while working on this PR to get it working there.

In conclusion, my work here is done for now and this is ready for review

[deleugpn]

• Nullsafe Operator
• Trailing Comma
• Named Parameter
• Attributes
• Constructor Property Promotion

[GrahamCampbell]

I think we can merge this without attributes working. A priority is getting PHP 7 compatible syntax to work on PHP 8, which this PR already does. A follow-up PR can add support for every PHP 8.0 feature (which is still a slightly moving target until RC1 comes out, anyway).

[GrahamCampbell]

A priority is getting PHP 7 compatible syntax to work on PHP 8

The lack of this is blocking Laravel from supporting PHP 8.0.

[GrahamCampbell]

This is still unresolved.

[deleugpn]

Thanks! I'll try to look into Attributes now that we're in RC stage of PHP.

[GrahamCampbell]

I've opened a separate issue to track this: #80. It is possible that we might only want to bother with attribute support in v4 of this package (after this PR has been re-implemented for v4). We can discuss on that new issue.

[mnapoli]

Ohh yeah thank you for merging, I'm working on PHP 8 support in PHP-DI and that was a blocker.

Hey there @deleugpn, fun seeing you here! 😄

[Blitheness]

Should the README be updated to mention PHP 8.0 support? At present, only PHP 5 and 7 are mentioned.