-
Notifications
You must be signed in to change notification settings - Fork 84
Comparing changes
Open a pull request
base repository: openfun/richie
base: v1.8.0
head repository: openfun/richie
compare: v1.8.1
- 10 commits
- 16 files changed
- 2 contributors
Commits on Aug 28, 2019
-
♻️(search) fix "more options" modal for non-mptt-paths based filters
The "more options" modal for filter values in the search filters pane incorrectly made the assumption that all searchable filters were based on MPTT paths and built a regexp accordingly. That is not the case: in our own sandbox environment, persons are not using those paths and the "more options" for persons modal is broken. We can simplify the regexp to make it work with every filter.
Configuration menu - View commit details
-
Copy full SHA for ec1b730 - Browse repository at this point
Copy the full SHA ec1b730View commit details -
🔒(dependencies) bump mixin-deep from 1.3.1 to 1.3.2
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8c754db - Browse repository at this point
Copy the full SHA 8c754dbView commit details -
♻️(search) improve error messages in the "more options" modal in filters
The "More options" modal for filter values was making request to the server as soon as the user started to type, and immediately showed a cryptic error message as it received an error for the server, because textual search only works in our API endpoints with 3 characters or more. Stop sending useless API requests when users input 1 or 2 characters and show a helpful message in the modal instead.
Configuration menu - View commit details
-
Copy full SHA for 2a2014c - Browse repository at this point
Copy the full SHA 2a2014cView commit details -
🤡(demo) increase courses & organizations numbers on demo site
We're using demo-content to showcase richie's feature set as best we can. In order to make a better demo for the "More options" modal on filters, and for course pagination, we're increasing the number or courses & organizations included in the demo site by default.
Configuration menu - View commit details
-
Copy full SHA for 91d4f2a - Browse repository at this point
Copy the full SHA 91d4f2aView commit details -
💬(news) improve a string in the blogpost detail template
The string shown in the blogpost detail template when a blogpost does not have an author - "No author yet." - should not have a period at the end as it is displayed between two dashes. Just remove the period from the string in the template.
Configuration menu - View commit details
-
Copy full SHA for 52f611d - Browse repository at this point
Copy the full SHA 52f611dView commit details -
🚸(search) improve pagination UX in course search
Our pagination as implemented in course search had two flaws: - low contrast difference between the currently active page button and other pages; - small clickable zone, only clicks on the page number itself triggered a page change, not clicks on the button itself. We made the clickable area encompass the whole page button, and used a reverse color scheme for the active page to make it more obvious for all users (and avoid a WCAG non-conformity for low contrast).
Configuration menu - View commit details
-
Copy full SHA for 6623910 - Browse repository at this point
Copy the full SHA 6623910View commit details -
🔒(dependencies) bump set-value to > 2.0.1
Regenerate the lockfile to ensure only versions > 2.0.1 (safe versions) of the `set-value` npm package are used.
Configuration menu - View commit details
-
Copy full SHA for 422d4bc - Browse repository at this point
Copy the full SHA 422d4bcView commit details
Commits on Aug 29, 2019
-
♻️(search) improve and complete strings in pagination
Visible pagination does not contain a lot of strings, but we have a few more strings for accessibility helpers that provide context along with the page numbers. We previously attempted to do this "smartly" through the HTML structure of our interpolated strings. This is not ideal as it works for english and some other languages, but fails for other languages with a different grammar. Also, we forgot a bunch of strings, which resulted in hardcoded english in our template.
Configuration menu - View commit details
-
Copy full SHA for f8f1075 - Browse repository at this point
Copy the full SHA f8f1075View commit details -
Pull and commit latest versions of the translations from our localization management tool.
Configuration menu - View commit details
-
Copy full SHA for 355e29d - Browse repository at this point
Copy the full SHA 355e29dView commit details -
🔖(chore) bump version to 1.8.1
Fixed - Fix "More options" modal for searchable filter values not based on MPTT paths (eg. "Person" in the sandbox environment). - Improve pagination UX by increasing contrast between the active page number and others, and making button clickable areas larger. - Stop making failed API requests and instead show a helpful error message in the "More options" modal for filter values when the user inputs their first 1 or 2 characters. - Improve pagination strings for localization. Security - Update the mixin-deep and set-value packages to safe versions.
Configuration menu - View commit details
-
Copy full SHA for 3cb5549 - Browse repository at this point
Copy the full SHA 3cb5549View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.8.0...v1.8.1