ENT-2657: Added COURSE_CATALOG_URL_ROOT to django settings #24248
Conversation
saleem-latif
requested review from
muhammad-ammar,
hasnain-naveed,
HammadAhmadWaqas,
irfanuddinahmad and
moconnell1453
or other option could be |
saleem-latif
force-pushed
the
saleem-latif/ENT-2657
branch
from
b5a9e06
to
ace1225
Compare
|
@moconnell1453 @HammadAhmadWaqas I have incorporated your feedback changes, please take another look. |
| @@ -3347,7 +3347,8 @@ def _make_locale_paths(settings): # pylint: disable=missing-function-docstring | |||
| ECOMMERCE_SERVICE_WORKER_USERNAME = 'ecommerce_worker' | |||
| ECOMMERCE_API_SIGNING_KEY = 'SET-ME-PLEASE' | |||
|
|
|||
| COURSE_CATALOG_API_URL = 'http://localhost:8008/api/v1' | |||
| COURSE_CATALOG_URL_ROOT = 'http://localhost:8008' | |||
| COURSE_CATALOG_API_URL = '{}/api/v1'.format(COURSE_CATALOG_URL_ROOT) | |||
There was a problem hiding this comment.
Question: What about overriding the complete URL instead of just ROOT URL? What if in future version v2 comes and we want to use the new version?
There was a problem hiding this comment.
@saleem-latif On a second look I am wondering the COURSE_CATALOG_URL_ROOT will override?
There was a problem hiding this comment.
Both of these settings will get overridden by https://github.com/edx/edx-platform/blob/master/lms/envs/production.py#L92
saleem-latif
force-pushed
the
saleem-latif/ENT-2657
branch
from
ace1225
to
85bf89d
Compare
|
jenkins run py38 python |
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Jira Ticket: ENT-2657
Description:
This PR adds
COURSE_CATALOG_URL_ROOTin django settings.