Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instructor_task: remove shoppingcart (DEPR-43) #23975

Merged
merged 1 commit into from
Jun 29, 2020
Merged

instructor_task: remove shoppingcart (DEPR-43) #23975

merged 1 commit into from
Jun 29, 2020

Conversation

nasthagiri
Copy link
Contributor

No description provided.

@nasthagiri nasthagiri requested a review from a team May 12, 2020 18:24
@feanil feanil force-pushed the depr/shoppingcart-instructor-report branch 4 times, most recently from 67eebbd to cdbfba2 Compare June 24, 2020 18:58
@feanil feanil requested a review from dianakhuang June 25, 2020 17:08
dianakhuang
dianakhuang approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@dianakhuang dianakhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Another 1k of code down.

@feanil feanil force-pushed the depr/shoppingcart-instructor-report branch from cdbfba2 to 80ea0a6 Compare June 29, 2020 14:28
@nasthagiri
Copy link
Contributor Author

Nice!

@feanil feanil merged commit cf5f948 into master Jun 29, 2020
@feanil feanil deleted the depr/shoppingcart-instructor-report branch June 29, 2020 15:05
@edx-status-bot
Copy link

Your PR has finished running tests. The following contexts failed:

  • jenkins/python-3.8/a11y
  • jenkins/python-3.8/python

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@nasthagiri nasthagiri added the depr Proposal for deprecation & removal per OEP-21 label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianakhuang dianakhuang dianakhuang approved these changes

Assignees
No one assigned
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nasthagiri @edx-status-bot @edx-pipeline-bot @dianakhuang @feanil