Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix hot reload serving of static resources #1980

Merged
merged 5 commits into from
Jun 21, 2023
Merged

fix: fix hot reload serving of static resources #1980

merged 5 commits into from
Jun 21, 2023

Conversation

nsprenkle
Copy link
Contributor

@nsprenkle nsprenkle commented Jun 20, 2023 •
edited
Loading

TL;DR - Fixes an issue where we weren't actually using an overridden dev server path in our local development workflows.

JIRA: JIRA-XXXX

What changed?

  • Edited loading of static scripts to be aware of base URL overrides.
  • Edited logic to correctly handle if loaded script is a root URL or a relative URL.

Developer Checklist

Testing Instructions

  • Follow developers guide to get a local install of ORA running, up to and including the Hot Reload Frontend Changes section.
  • Verify that changes to JS are getting loaded and live reloaded correctly.

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@codecov

This comment was marked as outdated.

Sign in to view
leangseu-edx
leangseu-edx approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@leangseu-edx leangseu-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nsprenkle nsprenkle marked this pull request as ready for review June 21, 2023 16:54
@nsprenkle nsprenkle requested a review from a team as a code owner June 21, 2023 16:54
@nsprenkle nsprenkle merged commit a397361 into master Jun 21, 2023
6 checks passed
@nsprenkle nsprenkle deleted the aurora/hot-reload-fix branch June 21, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leangseu-edx leangseu-edx leangseu-edx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsprenkle @leangseu-edx