Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add tx in the path for transifex commands #1890

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

UsamaSadiq
Copy link
Member

Description

  • Add transifex client make command #1889 added new Make command to install transifex client locally.
  • To run the client locally, the path for the tx in make pull_translations command was updated.
  • Updating the path caused the scheduled pull_translations job to fail on Jenkins.
  • Reverted the pull_translations command update and instead added the new client in the PATH to make it accessible everywhere in the directory.

@UsamaSadiq UsamaSadiq requested a review from a team as a code owner September 6, 2022 13:10
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Base: 94.98% // Head: 94.98% // No change to project coverage 👍

Coverage data is based on head (cb50a1a) compared to base (835c1e2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1890   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files         154      154           
  Lines       17045    17045           
  Branches     1873     1873           
=======================================
  Hits        16190    16190           
  Misses        641      641           
  Partials      214      214           
Flag Coverage Δ
unittests 94.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@UsamaSadiq UsamaSadiq merged commit e85ec5f into master Sep 6, 2022
@UsamaSadiq UsamaSadiq deleted the usamasadiq/add-transifex-client-make-command branch September 6, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants