{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":116327333,"defaultBranch":"master","name":"bmcweb","ownerLogin":"openbmc","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-01-05T01:50:42.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/13670043?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1718043417.0","currentOid":""},"activityList":{"items":[{"before":"26d3b0fb502ba522c33621e43c9679d47c7db2d2","after":"d3e0859cb6cd76ab30204aad107971a6e1b59b5d","ref":"refs/heads/master","pushedAt":"2024-09-27T18:07:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"sdbusplus: use shorter type aliases\n\nThe sdbusplus headers provide shortened aliases for many types.\nSwitch to using them to provide better code clarity and shorter\nlines. Possible replacements are for:\n * bus_t\n * exception_t\n * manager_t\n * match_t\n * message_t\n * object_t\n * slot_t\n\nChange-Id: I1c12dfb9df9e4a86e4c13ec16bbf8beeff6edb10\nSigned-off-by: Patrick Williams ","shortMessageHtmlLink":"sdbusplus: use shorter type aliases"}},{"before":"a14c9113226dcae33a36eb4e50abbcc28be998ae","after":"26d3b0fb502ba522c33621e43c9679d47c7db2d2","ref":"refs/heads/master","pushedAt":"2024-09-26T17:09:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Fix error codes\n\nChanges added : Added error code for invalid certificate\n\nProblem : When Invalid certificate was passed to replace certificate\nIt was throwing error Internal error\n\nBelow is the redfishtool log:\n\nredfishtool: Transport: Response Error: status_code: 500 --\nInternal Error\nredfishtool: raw: Error sending POST to resource, aborting\n\nSolution : Return proper error code that is 400 -- Bad Request\n\nTested : I tested with redfish tool and below is the log\nwith correct error code\n\nredfishtool: Transport: Response Error: status_code: 400 --\nBad Request\n redfishtool: raw: Error sending POST to resource, aborting\n\nChange-Id: I71e7a72a4c156dc80321641f279c20aff4bd6df1\nSigned-off-by: Chandramohan Harkude ","shortMessageHtmlLink":"Fix error codes"}},{"before":"262dcc1ca87af630218644204fc6948f7f592b9f","after":"a14c9113226dcae33a36eb4e50abbcc28be998ae","ref":"refs/heads/master","pushedAt":"2024-09-23T15:50:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Add extra subscription params support\n\nOriginResource allows filtering messages on a per-device basis. This\nwas already listed as supported in our docs.\n\nRegistryPrefixes is also added.\n\nTested: Unit tests pass.\n\nChange-Id: Idfde8416f2f466ce11957177e052b540fc669888\nSigned-off-by: Ed Tanous ","shortMessageHtmlLink":"Add extra subscription params support"}},{"before":"878edd599b1706ec8ffe6c3d81ba7cb3534f6393","after":"262dcc1ca87af630218644204fc6948f7f592b9f","ref":"refs/heads/master","pushedAt":"2024-09-23T14:42:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"event logs: introduce struct DbusEventLogEntry\n\nThis creates a partial representation of dbus interface\nxyz.openbmc_project.Logging.Entry as a struct.\n\nThere is also a function to extract it from dbus.\n\nWhich helps to refactor function fillEventLogLogEntryFromPropertyMap\nto be smaller.\n\nTested: not tested, simple refactoring. All the data types remain the\nsame as before.\n\nChange-Id: Ib32cac967bde487b137ceaf845dfb682e605a175\nSigned-off-by: Alexander Hansen ","shortMessageHtmlLink":"event logs: introduce struct DbusEventLogEntry"}},{"before":"8812e8becaf44d810e68ed80692c2797b2f114ac","after":"878edd599b1706ec8ffe6c3d81ba7cb3534f6393","ref":"refs/heads/master","pushedAt":"2024-09-20T00:34:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Re-eenable boost concepts\n\nWe disabled this to fight some old boost bugs around the initial run of\nconcepts. Between new compilers and new boost these seem solved, so\nre-enable the concepts.\n\nTested: Unit tests pass. Has coverage of asio.\n\nChange-Id: Ib430bff53635acecaf184ab2eadd8cde3900a19b\nSigned-off-by: Ed Tanous ","shortMessageHtmlLink":"Re-eenable boost concepts"}},{"before":"6440c77c68fe9daa1a92fabd2babc1c7838ded35","after":"8812e8becaf44d810e68ed80692c2797b2f114ac","ref":"refs/heads/master","pushedAt":"2024-09-18T16:55:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Do not remove wrong cookies on Session DELETE\n\nWhen a web interface sends a DELETE request for a session other than\nit's using itself the reply shouldn't ask the web browser to delete the\ncookies and to clear the site data.\n\nTested: logging in to BMC, observing the session identifier returned by\nPOST to Sessions, then opening another private window and logging in on\nthe same BMC, getting another session ID. Then navigating to \"Security\nand access -> Sessions\" and pressing \"Disconnect\" button for the session\nopened in the first window just deletes the session normally and the web\ninterface of the second private window that performed the operation\ncontinued to work. Pressing \"Log out\" deletes the current session and\nthe web browser gets expected cookie and site data clearing headers.\nBefore the patch the same test made the second private window lose its\ncookies essentially terminating both sessions instead of just the other\none.\n\nFixes: 29aab242f2d3 (\"Send cookies to webui-vue from Sessions POST\")\nChange-Id: If3f81764cb825253b9d6e1c7589340e6dc018a81\nSigned-off-by: Paul Fertser ","shortMessageHtmlLink":"Do not remove wrong cookies on Session DELETE"}},{"before":"dd5c81e9e330c20f534496174472efb6fe2c112e","after":"6440c77c68fe9daa1a92fabd2babc1c7838ded35","ref":"refs/heads/master","pushedAt":"2024-09-17T18:51:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Update symlinks for 2024.3\n\nWrote a quick bash script to update these symlinks and rename the files.\n\nThese are versioned out in json schema directory[1].\n\nThe symlinks don't work without this update.\n\n[1]: https://github.com/openbmc/bmcweb/tree/master/redfish-core/schema/dmtf/json-schema\n\nTested: None. Inspection only.\n\nChange-Id: Ifaa8f9879a4b25bd59717dd5692a17dbdb71aa1d\nSigned-off-by: Gunnar Mills ","shortMessageHtmlLink":"Update symlinks for 2024.3"}},{"before":"d51c61b4b7b57cf1b662f03dc99819bf025f283a","after":"dd5c81e9e330c20f534496174472efb6fe2c112e","ref":"refs/heads/master","pushedAt":"2024-09-17T18:51:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Update to 2024.3\n\n1 line change in update_schemas.py and rerun it.\n\nSee below for more info on this release:\nhttps://www.dmtf.org/content/redfish-release-20243-now-available\n\nTested: Inspection only.\n\nChange-Id: I856b9777fd386f828724bd7a521dcd5c8c3270cf\nSigned-off-by: Gunnar Mills ","shortMessageHtmlLink":"Update to 2024.3"}},{"before":"cd5a898fd4007212ce9e58ea9443071da494452e","after":"d51c61b4b7b57cf1b662f03dc99819bf025f283a","ref":"refs/heads/master","pushedAt":"2024-09-16T15:47:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Fix status for non-existent JsonSchema FileGet\n\nThis will fix the incorrect status 500 to status 404 for the\nnon-eixstent JsonSchema FileGet.\n\n```\n% redfishtool raw GET -r ${bmc} -u root -p 0penBmc -S Always /redfish/v1/JsonSchemas/ComputerSystem/ComputerSystem.v1_99_1.json\n redfishtool: Transport: Response Error: status_code: 500 -- Internal Server Error\n redfishtool: raw: Error getting response\n```\n\nThis commit also refactor `Response::openFile()` to return `ec` so that\nthe caller can check the reason of the failure.\n\nTested:\n- Verify redfishtool result for the non-existent JsonSchema file like\n```\n% redfishtool raw GET -r ${bmc} -u root -p 0penBmc -S Always /redfish/v1/JsonSchemas//.json\n redfishtool: Transport: Response Error: status_code: 404 -- Not Found\n redfishtool: raw: Error getting response\n```\n- Redfish Service validator passes\n\nChange-Id: I98927c076bb6e7dfb3742183b4b3545e328d2657\nSigned-off-by: Myung Bae ","shortMessageHtmlLink":"Fix status for non-existent JsonSchema FileGet"}},{"before":"77dcace654b2a2627de56fb7b98d29172a2b55fb","after":"cd5a898fd4007212ce9e58ea9443071da494452e","ref":"refs/heads/master","pushedAt":"2024-09-13T21:55:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Sensors: Add SpeedRPM property\n\nChanges here are to add support for Redfish for Thermal Equipment[1].\n\nAdd the SpeedRPM property for a Rotational fan sensor. This property is\npart of the Redfish Sensor schema since version 1_2_0.[2]\n\nThis change is so we will always have a property with the RPM. This\nallows a client (e.g. webui-vue) to always look for the SpeedRPM\nproperty.\n\nNote: Redfish defines the Reading property for a fan to be a\npercentage value. Currently for this type of fan sensor the Reading\nvalue is being set to the RPM value. To preserve backwards\ncompatibility the SpeedRPM property is added without altering the\nReading value. However this may change in the future to match the\nexpected Redfish implementation. Clients are advised to use the new\nSpeedRPM value to assure continuing correct function.\n\n[1] https://www.dmtf.org/sites/default/files/standards/documents/DSP2064_1.0.0.pdf\n[2] http://redfish.dmtf.org/schemas/v1/Sensor.v1_10_0.json#/definitions/Sensor\n\nImplementation Note: The objectPropertiesToJson() has existing else\nif(sensorType ==) statements. However because the first if()\nstatement is looking at the chassisSubNode these are never visited for\nsensors when using the\n/redfish/v1/Chassis//Sensors/ URI.\nThose existing sensorType comparisons are used for the\nredfish-allow-deprecated-power-thermal Redfish interfaces.\n\n```\n$ curl -k -H \"X-Auth-Token: $token\" https://${bmc}/redfish/v1/Chassis/chassis/Sensors/fantach_fan1_0\n{\n \"@odata.id\": \"/redfish/v1/Chassis/chassis/Sensors/fantach_fan1_0\",\n \"@odata.type\": \"#Sensor.v1_2_0.Sensor\",\n \"Id\": \"fantach_fan1_0\",\n \"Name\": \"fan1 0\",\n \"Reading\": 18000.0,\n \"ReadingType\": \"Rotational\",\n \"ReadingUnits\": \"RPM\",\n \"SpeedRPM\": 18000.0,\n \"Status\": {\n \"Health\": \"OK\",\n \"State\": \"Enabled\"\n }\n}\n```\n\nTested:\n- Redfish Validator passes\n\nChange-Id: Icd39fd70d4a24aafab0d9b66fa09c000b97b3199\nSigned-off-by: Janet Adkins ","shortMessageHtmlLink":"Sensors: Add SpeedRPM property"}},{"before":"6d799e14ccc18da425f9c6413df132ea905907eb","after":"77dcace654b2a2627de56fb7b98d29172a2b55fb","ref":"refs/heads/master","pushedAt":"2024-09-13T21:54:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Reorganize gtest\n\nCurrently, gtest is included as a source library. This means that every\ntest application compiles its own version of gtest. This is wasteful,\neven though it's likely not that expensive compared to other compile\ntime things.\n\nMove gtest into a library, upgrade our version of gtest at the same\ntime.\n\nTested: unit tests pass\n\nChange-Id: I5064848bd42d6b119a8d4aa9bcac13ad8ec65955\nSigned-off-by: Ed Tanous ","shortMessageHtmlLink":"Reorganize gtest"}},{"before":"ad6dd39b19376d19dce68ee71a684b9b61579df1","after":"6d799e14ccc18da425f9c6413df132ea905907eb","ref":"refs/heads/master","pushedAt":"2024-09-13T19:25:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Rename sendEvent\n\nThere are currently 3 function prototypes that hold the name\n\"sendEvent\". This makes them hard to search for, and even though they\ntake different arguments, and are attached to different classes, they're\nstill difficult to trace.\n\nRename two of the classes.\n\nTested: Code compiles. Rename only.\n\nChange-Id: I5df9c690ba0ca8ebe19c73fc0848e9c3ef4d52f7\nSigned-off-by: Ed Tanous ","shortMessageHtmlLink":"Rename sendEvent"}},{"before":"fe37ddaf26abcf67e3861e2af3177333b09204f5","after":"ad6dd39b19376d19dce68ee71a684b9b61579df1","ref":"refs/heads/master","pushedAt":"2024-09-13T19:14:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"websocket: Handle eof and truncated stream\n\nWhen doRead() fails, the code was checking the `closed` error code and\nprint the error log if it's other error codes.\nIn field we noticed that the error code could be `eof` or\n`stream_truncated` if the websocket gets closed.\nAdd the above error codes as well so that it does not print error log on\nclosed websocket.\n\nSigned-off-by: Lei YU \nChange-Id: Id25f9750521d67643a125d7641eb73c75c328a85","shortMessageHtmlLink":"websocket: Handle eof and truncated stream"}},{"before":"6be832e2963e9d720dd95543358eca380c5e52d2","after":"fe37ddaf26abcf67e3861e2af3177333b09204f5","ref":"refs/heads/master","pushedAt":"2024-09-13T12:22:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Fix 404 status from JsonSchemas FileGet\n\nThis will fix the 404 error from JsonSchema FileGet\n\n```\nredfishtool raw GET -r ${bmc} -u root -p 0penBmc -S Always /redfish/v1/JsonSchemas/ComputerSystem/ComputerSystem.v1_22_2.json\n redfishtool: Transport: Response Error: status_code: 404 -- Not Found\n redfishtool: raw: Error getting response\n```\n\nTested:\n- Get `/redfish/v1/JsonSchemas//` and use its\n`Location/Uri` for the next redfishtool\n- Verify redfishtool result like\n```\nredfishtool raw GET -r ${bmc} -u root -p 0penBmc -S Always /redfish/v1/JsonSchemas//..json\n```\n- Redfish Service validator passes\n\nChange-Id: I0ca443177537d0a73a31a7195deb3cfb028c49b5\nSigned-off-by: Myung Bae ","shortMessageHtmlLink":"Fix 404 status from JsonSchemas FileGet"}},{"before":"8759961c6b9a901484a53c913e7ddd7e71bae1c9","after":"6be832e2963e9d720dd95543358eca380c5e52d2","ref":"refs/heads/master","pushedAt":"2024-09-11T15:34:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Remove duplicated block comments\n\nStatic analysis flags that these two comments are redundant[1], which\nseem to be duplicated a lot in copyright headers. Although there is a\nlarger discussion that can likely be had.\n\n[1] https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=edtanous_bmcweb&open=AY9_HYjgKXKyw1ZFwgVP\n\nTested: Comment change only. Code compiles.\n\nChange-Id: Ia960317761f558a87842347ca0b5f3da63f8e730\nSigned-off-by: Ed Tanous ","shortMessageHtmlLink":"Remove duplicated block comments"}},{"before":"ab0d439013c3a42a8221f8718124bcc897ac21ab","after":"8759961c6b9a901484a53c913e7ddd7e71bae1c9","ref":"refs/heads/master","pushedAt":"2024-09-11T15:09:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Fix EventDesition schema version usage\n\nEventService Subscription adds `VerifyCertificate`, but it needs\nto use #EventDestination schema version 1.9.0 [1] or higher.\n\nBefore the fix, Redfish Service Validator gives the error like\n\n```\n1 failAdditional errors in /redfish/v1/EventService/Subscriptions/4022728919\n1 fails errors in /redfish/v1/EventService/Subscriptions/4022728919\nERROR - VerifyCertificate not defined in schema EventDestination.v1_8_0 (check version, spelling and casing)\n```\n\nTested:\n- Redfish Service Validator passes\n\n[1] http://redfish.dmtf.org/schemas/v1/EventDestination.v1_9_0.json\n\nChange-Id: Id9ece4bd1b69aaa004ab6db863900942023c09ec\nSigned-off-by: Myung Bae ","shortMessageHtmlLink":"Fix EventDesition schema version usage"}},{"before":"64d8e80d4e55eabfb4c494ed35c6b8b1d45b8dc4","after":"ab0d439013c3a42a8221f8718124bcc897ac21ab","ref":"refs/heads/master","pushedAt":"2024-09-11T14:02:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Fix IPv6 static default gateway\n\nThis commit updates IPv6 static default gateway implementation\nto use updated D-bus interfaces\n\nPrefixLength property removed from StaticGateway D-bus interface\nhttps://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/71271\n\nTested by:\n-d '{\"IPv6StaticDefaultGateways\":\n [{\"Address\": \"2006:905:15F:36:10:10:3:1\"}]}'\n-d '{\"IPv6StaticDefaultGateways\":\n [{},{\"Address\": \"2007:905:18F:36:10:9:5:1\"}]}'\n\nChange-Id: Ia90605d65652990f13c442bb21e2d796e6660587\nSigned-off-by: Ravi Teja ","shortMessageHtmlLink":"Fix IPv6 static default gateway"}},{"before":"03d4d37c2132d217b55ab5cc66fc61d5a7c2d3c1","after":"64d8e80d4e55eabfb4c494ed35c6b8b1d45b8dc4","ref":"refs/heads/master","pushedAt":"2024-09-10T22:49:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"dbus_utility: Support new ObjectMapper methods\n\nThe new ObjectMapper methods are added as part of\n\nhttps://gerrit.openbmc.org/c/openbmc/phosphor-objmgr/+/70699\n\n- GetAssociatedSubTreeById\n- GetAssociatedSubTreePathsById\n\nThe two methods are meant to be used to replace places where two dbus\ncalls are used to get associated objects\n\nChange-Id: Ia6dc198ea3c63b9d5a49ba09f1fa999381de8a7c\nSigned-off-by: Lakshmi Yadlapati ","shortMessageHtmlLink":"dbus_utility: Support new ObjectMapper methods"}},{"before":"1d19d872bb9195b8f1f340771c087ca43f756b5f","after":"03d4d37c2132d217b55ab5cc66fc61d5a7c2d3c1","ref":"refs/heads/master","pushedAt":"2024-09-10T16:37:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"event service manager: more meaningful debug logs\n\nWhen debugging event subscriptions, this helps to investigate where a\nparticular event was filtered or experienced some validation error.\n\nChange-Id: If08ac5c7d2dea5921261a8a464d3ea6899615df5\nSigned-off-by: Alexander Hansen ","shortMessageHtmlLink":"event service manager: more meaningful debug logs"}},{"before":"4ff0f1f4a70440504f0619f0d12f0828c880d03c","after":"1d19d872bb9195b8f1f340771c087ca43f756b5f","ref":"refs/heads/master","pushedAt":"2024-09-10T14:34:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Fix Missed Renamed OpenBMCManager word\n\nThe commit fc1cdd14 misses a word change from OemManager to\nOpenBMCManager in meson.options.\n\nTested: Inspection only\n\nChange-Id: I9fd1da737656ffe5136bd9298f35a0dc527d4870\nSigned-off-by: Myung Bae ","shortMessageHtmlLink":"Fix Missed Renamed OpenBMCManager word"}},{"before":"f836c1d81313fad026197b36d32313480ada3a21","after":"4ff0f1f4a70440504f0619f0d12f0828c880d03c","ref":"refs/heads/master","pushedAt":"2024-09-10T04:10:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"static -> inline\n\nDeclaring a function static in a header makes no sense, because a header\nisn't a compile unit. Find all the issues and replace them with inline.\n\nChange-Id: Icfc2b72d94b41a3a880da1ae6975beaa30a6792b\nSigned-off-by: Ed Tanous ","shortMessageHtmlLink":"static -> inline"}},{"before":"e3142e80dc05632d04a1cc4c9539225afa4ab391","after":"f836c1d81313fad026197b36d32313480ada3a21","ref":"refs/heads/master","pushedAt":"2024-09-09T23:12:41.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Fix static analysis\n\nMaking these const means that we can no longer use std::move on this\nstruct, which static analysis flags.\n\n[1] https://sonarcloud.io/project/issues?impactSeverities=HIGH&issueStatuses=OPEN%2CCONFIRMED&tags=since-c%2B%2B11&types=CODE_SMELL&id=edtanous_bmcweb&open=AZHJOZJsIkxRoiGIkzZz\n\nChange-Id: I10c33f37ce14650962a7840729d75639ee8edb2e\nSigned-off-by: Ed Tanous ","shortMessageHtmlLink":"Fix static analysis"}},{"before":"a553291f5179816c547db3a3baa36ad06b14626e","after":"e3142e80dc05632d04a1cc4c9539225afa4ab391","ref":"refs/heads/master","pushedAt":"2024-09-09T19:04:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Remove unused OemComputerSystem json file\n\nThe previous commit 1d834d4[1] renamed OemComputerSystem json\nto OpenBmcComputerSystem json, but forgot to delete the old one.\n\nTested: Inspection only.\n\n[1] https://github.com/openbmc/bmcweb/commit/1d834d49cc0d2dcee11f203b167434aeefcb7970\n\nChange-Id: Ia5512f0c9ea249742e0ac5fa3c7d0d120f824c36\nSigned-off-by: Myung Bae ","shortMessageHtmlLink":"Remove unused OemComputerSystem json file"}},{"before":"7805ca2f7fb295ca5f8a314c5b7a85f944b9b74f","after":"a553291f5179816c547db3a3baa36ad06b14626e","ref":"refs/heads/master","pushedAt":"2024-09-09T04:30:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Improve bmcweb CLI app\n\nEnhance bmcweb CLI app error messages. Replace the loglevel flag with a\nsubcommand called \"loglevel\". Handle case where empty log levels were\nbeing propagated to bmcwebd.\n\nInvalid logging values are handled by the CLI. List of available states\ncan be determined by using the command:\nbmcweb loglevel -h\n\nExample:\nbmcweb loglevel DEBUG\nbmcweb loglevel debug\n\nChange-Id: Iaac3f674109e5d86f6c0cd7c1b930ee1c9c594e2\nSigned-off-by: Aushim Nagarkatti ","shortMessageHtmlLink":"Improve bmcweb CLI app"}},{"before":"a0735a4e58454950b3f7c17711fa1eaa6372d6b9","after":"7805ca2f7fb295ca5f8a314c5b7a85f944b9b74f","ref":"refs/heads/master","pushedAt":"2024-09-07T15:27:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Fix OpenBMC JsonSchemas installation\n\nThis fixes the missing Oem/OpenBMC JsonSchema file installation.\n\nTested:\n- Check JsonSchemas to have the enabled OpenBMC schemas\n```\ncurl -k -X GET https::/${bmc}/redfish/v1/JsonSchemas/OpenBMCAccountService\ncurl -k -X GET https::/${bmc}/redfish/v1/JsonSchemas/OpenBMCManager\ncurl -k -X GET https::/${bmc}/redfish/v1/JsonSchemas/OpenBMCComputerSystem\n```\n\nChange-Id: Ia13b5c5d1626ee5648ddce5cd62375c8e3e09e75\nSigned-off-by: Myung Bae ","shortMessageHtmlLink":"Fix OpenBMC JsonSchemas installation"}},{"before":"c44cddd8a2ce76309e3ee238b30ed538191e0945","after":"a0735a4e58454950b3f7c17711fa1eaa6372d6b9","ref":"refs/heads/master","pushedAt":"2024-09-07T00:04:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"User creation: Add EC to Log\n\nOn an internal error, having the error code from D-Bus is really\nhelpful to debug. A trace before an internal error without the ec, is\npretty pointless so make this trace useful.\n\nTested: None. Inspection only.\n\nChange-Id: I953e5bcbbba197b158beabdb55f57b4fd3d73125\nSigned-off-by: Gunnar Mills ","shortMessageHtmlLink":"User creation: Add EC to Log"}},{"before":"f3025d9f4285de05a20211f662f549c0a86800ee","after":"c44cddd8a2ce76309e3ee238b30ed538191e0945","ref":"refs/heads/master","pushedAt":"2024-09-06T14:58:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Format OEM schemas with xmllint\n\nOur OEM schemas still have whitespace violations. Reformat using\nxmllint --format.\n\nTested: Whitespace changes only. Code compiles.\n\nChange-Id: Ic240d7b7c617991005d72313183b20d452273662\nSigned-off-by: Ed Tanous ","shortMessageHtmlLink":"Format OEM schemas with xmllint"}},{"before":"0c728b42ceb9efa2c1a378edf27ab5016a5dbea8","after":"f3025d9f4285de05a20211f662f549c0a86800ee","ref":"refs/heads/master","pushedAt":"2024-09-05T15:40:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Correct OpenBMCComputerSystem schema content\n\nCorrect the incorrect collection uri of OpenBMCComputerSystem_v1.xml.\n\nTested:\n- Verify that the old uri is invalid\n- Verify that the corrected uri is valid\n\nChange-Id: Ica013733d995da0e41711eca715609b54b161e1d\nSigned-off-by: Myung Bae ","shortMessageHtmlLink":"Correct OpenBMCComputerSystem schema content"}},{"before":"9d62d1269dee1bf6324b95395c40676ba21cb3c6","after":"0c728b42ceb9efa2c1a378edf27ab5016a5dbea8","ref":"refs/heads/master","pushedAt":"2024-09-04T21:29:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Sensors: Add enum for chassis sub nodes\n\nAdded ChassisSubNode enum for defining the different chassis subNode\npaths to retrieving sensor data.\n\nModified path building sensor data to use the enum. Other paths were\nleft still using the string. Specifically the paths using\nSensorsAsyncResp as these primarily use the strings for human readable\noutput.\n\nAdded utility functions to convert to/from enum to string value.\nAdded unit tests for new utility functions.\n\nTested:\n - Verified sensor paths before and after change had no change:\n - /redfish/v1/Chassis/chassis/Sensors\n - /redfish/v1/Chassis/chassis/Thermal\n - /redfish/v1/Chassis/chassis/Power\n - Selection of: /redfish/v1/Chassis/chassis/Sensors/\n - /redfish/v1/Chassis/chassis/Sensors?\\$expand=*\n - Redfish Validator passes\n\nChange-Id: I02bb5f3c0c49d85dbd1dff911d9f1a8467d6b1db\nSigned-off-by: Janet Adkins ","shortMessageHtmlLink":"Sensors: Add enum for chassis sub nodes"}},{"before":"d193e0082c3fc7d4f4c34dd5fa86e95c036c938d","after":"9d62d1269dee1bf6324b95395c40676ba21cb3c6","ref":"refs/heads/master","pushedAt":"2024-09-04T21:25:10.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Correct comment to reflect PrivilegeRegistry\n\nLooking at\nhttps://redfish.dmtf.org/registries/Redfish_1.5.0_PrivilegeRegistry.json\na \"Entity\": \"LogService\", is\n\n \"POST\": [\n {\n \"Privilege\": [\n \"ConfigureManager\"\n\nbelow it is a SubordinateOverrides for\n \"Targets\": [\n \"ComputerSystem\",\n\nwith\n\n \"POST\": [\n {\n \"Privilege\": [\n \"ConfigureComponents\"\n\nwhich is what this LogService is. Update the comment to reflect the\nConfigureComponents is correct.\n\nFound in review on https://gerrit.openbmc.org/c/openbmc/bmcweb/+/74272/\n\nTested: Inspection only. Comment change only.\n\nChange-Id: I4ffc7d973bb7146c78a8762dde1a42f4c4203a3c\nSigned-off-by: Gunnar Mills ","shortMessageHtmlLink":"Correct comment to reflect PrivilegeRegistry"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yN1QxODowNzoxMy4wMDAwMDBazwAAAATC5UEJ","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0wNFQyMToyNToxMC4wMDAwMDBazwAAAAStLXOQ"}},"title":"Activity ยท openbmc/bmcweb"}