Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New
info
API for vectorized environments #2657 #2773New
info
API for vectorized environments #2657 #2773Changes from 32 commits
8267cee
26da959
fca5d32
b22f9b2
00b876d
90fb9ec
ceb8d2e
fee3722
891b927
efe22cb
8061306
029980c
8667dda
c3855e5
d09cc0c
b05f7e6
ad003bb
a1340c5
f704758
ad89471
4a4efe9
9693b35
36051b7
f2b4ab3
35041d9
cb2b993
0d1522d
be23655
9532b51
6593114
479bc8b
b9a862b
761b576
7a488b7
0e3e201
d2f8b1b
03e0627
e433d34
ee556aa
f92b75e
17b8cd3
29ec6bf
5e2aead
a2b186a
555bacc
d6eb5e7
db21ebc
0a02bd5
659b8fc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some explicit handling for numpy arrays too? I think the current implementation can cause some problems through a mixup between e.g.
np.float32
andnp.float64
, or it will even default to theobject
type. And I can easily see passing an array in the info dict as a desired functionalityThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem for me, atm if an array is added to the info dict the resulting output will fall in the
object
dtype resulting in this:Something I can think of is making the output in this form:
I'm not sure this adhere to the format of google-brax tho